From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wlds1-0003EX-Mj for qemu-devel@nongnu.org; Sat, 17 May 2014 08:37:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wldrv-00064I-71 for qemu-devel@nongnu.org; Sat, 17 May 2014 08:37:45 -0400 Received: from mail-pa0-x22e.google.com ([2607:f8b0:400e:c03::22e]:49300) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wldru-00064C-Vo for qemu-devel@nongnu.org; Sat, 17 May 2014 08:37:39 -0400 Received: by mail-pa0-f46.google.com with SMTP id kq14so3700270pab.19 for ; Sat, 17 May 2014 05:37:37 -0700 (PDT) Message-ID: <5377580A.5060209@gmail.com> Date: Sat, 17 May 2014 20:37:30 +0800 From: Jun Li MIME-Version: 1.0 References: <1399739757-3111-1-git-send-email-juli@redhat.com> <20140514124036.GD16683@stefanha-thinkpad.redhat.com> <20140514130538.GA19672@T430.nay.redhat.com> In-Reply-To: <20140514130538.GA19672@T430.nay.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v3] snapshot: fixed bdrv_get_full_backing_filename can not get correct full_backing_filename List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , Stefan Hajnoczi Cc: kwolf@redhat.com, Jun Li , qemu-devel@nongnu.org, stefanha@redhat.com On 05/14/2014 09:05 PM, Fam Zheng wrote: > On Wed, 05/14 14:40, Stefan Hajnoczi wrote: >> On Sun, May 11, 2014 at 12:35:57AM +0800, Jun Li wrote: >>> From: Jun Li >>> >>> This patch fixed the following bug: >>> https://bugzilla.redhat.com/show_bug.cgi?id=1084302 . >>> >>> path_combine can not calculate the correct full path name for backing_file. >>> Such as: >>> create a snapshot chain: >>> sn2->sn1->$BASE_IMG >>> backing file is : /home/wookpecker/img.qcow2 >>> sn1 : /home/woodpecker/tmp/sn1 >>> sn2 : /home/woodpecker/tmp/sn2 >>> when create sn2, path_combine can not got a correct path for $BASE_IMG. >>> >>> In this patch, will check the backing_filename is a symlink or not firstly, >>> then return the full(absolute) path via realpath. >>> >>> Signed-off-by: Jun Li >>> --- >>> block.c | 18 +++++++++++++++++- >>> 1 file changed, 17 insertions(+), 1 deletion(-) >> Please fix your patch email submission process so it doesn't send the >> same patch multiple times. ok , thx. >> You've done this several times in the past. It makes patch review more >> difficult than it needs to be for reviewers. If I have to compare >> several emails and figure out which patch is the right one before >> reviewing I'm inclined not to review at all. ok, thank you very much. >> > This is indeed very confusing. (I've showed Jun the configuration I have to > send patches.) > > If you hit enter too quickly or forgot something, it's OK to try again, but > using distinct subjects is important and makes it easier for us to know what's > happening. > > If, by mistake the subjects you send are the same, please reply yourself to the > list, saying "please ignore this one", so we know which to look at. ok, got it. Thx. > > Fam Thanks Fam and Stefan, I have configured my msmtp(via gmail) successfully. As I specify the wrong smtpserver with smtp.gmail.com beforeļ¼Œ now the gmail smtpserver is smtp.googlemail.com. Best Regards, Jun Li