From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59917)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1Wlwna-0000Ku-IK
	for qemu-devel@nongnu.org; Sun, 18 May 2014 04:50:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1WlwnU-0007yE-V3
	for qemu-devel@nongnu.org; Sun, 18 May 2014 04:50:26 -0400
Received: from mout.web.de ([212.227.17.12]:52582)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1WlwnU-0007xF-LQ
	for qemu-devel@nongnu.org; Sun, 18 May 2014 04:50:20 -0400
Message-ID: <53787446.4070600@web.de>
Date: Sun, 18 May 2014 10:50:14 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
MIME-Version: 1.0
References: <B0F10CD9-253D-4AF8-8A3D-623DEEABF759@bartoli.org>
In-Reply-To: <B0F10CD9-253D-4AF8-8A3D-623DEEABF759@bartoli.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] OS X compile fix
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Bartoli <peter@bartoli.org>, qemu-devel <qemu-devel@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Stefan Hajnoczi <stefanha@redhat.com>

Hi,

Am 18.05.2014 01:14, schrieb Peter Bartoli:
> 
> At the recommendation of Mark Cave-Ayland, I'm sending this patch in to
> remedy a long-time Mac OS X compile issue.

Define "long-time"? 2.0 compiled just fine for me on v10.5.8 with
gcc-4.2. I see a number of deprecation and possibly-used-uninitialized
warnings but no breakage. What OSX version and what compiler are you
using, and what error or warning are you seeing without your patch?

Right now on qemu.git I have a different build issue: In scripts/qapi.py
"except IOError as e" needs to be "except IOError, e". But
block/raw-posix.c still builds fine here.

>  The offsets are a way off in
> this diff, but it still works.

Offsets are not the only issue with this "patch", see
http://wiki.qemu-project.org/Contribute/SubmitAPatch

* HTML format
* No Signed-off-by
* No [PATCH]
* Block maintainers not CC'ed (not so important here)
* Insufficient description of what is being fixed

Regards,
Andreas

> --- block/raw-posix.c.orig      2012-12-03 11:37:05.000000000 -0800
> +++ block/raw-posix.c   2012-12-03 18:24:47.000000000 -0800
> @@ -914,11 +914,11 @@
>                          size = 0;
>          }
>          if (size == 0)
>  #endif
>  #if defined(__APPLE__) && defined(__MACH__)
> -        size = LONG_LONG_MAX;
> +        size = LLONG_MAX;
>  #else
>          size = lseek(fd, 0LL, SEEK_END);
>  #endif
>  #if defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
>          switch(s->type) {