From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43599) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmHL5-000472-VI for qemu-devel@nongnu.org; Mon, 19 May 2014 02:46:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WmHL1-0000Cz-1A for qemu-devel@nongnu.org; Mon, 19 May 2014 02:46:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54301) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmHL0-0000CY-Q9 for qemu-devel@nongnu.org; Mon, 19 May 2014 02:46:18 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4J6kItj026213 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 19 May 2014 02:46:18 -0400 Message-ID: <5379A8AF.2030401@redhat.com> Date: Mon, 19 May 2014 08:46:07 +0200 From: =?ISO-8859-1?Q?J=E1n_Tomko?= MIME-Version: 1.0 References: <53752F73.3030506@redhat.com> <87r43uuuvp.fsf@blackfin.pond.sub.org> <5375AC0C.1040708@redhat.com> <20140516091359.27148f00@redhat.com> In-Reply-To: <20140516091359.27148f00@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wQqkLk7hltAfPXOHqSTqAmDfkh8Sa0pPn" Subject: Re: [Qemu-devel] [libvirt] [PATCHv2] Don't log an internal error when the guest hasn't updated balloon stats List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino , Eric Blake Cc: libvir-list@redhat.com, "qemu-devel@nongnu.org" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wQqkLk7hltAfPXOHqSTqAmDfkh8Sa0pPn Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 05/16/2014 03:13 PM, Luiz Capitulino wrote: > On Fri, 16 May 2014 00:11:24 -0600 > Eric Blake wrote: >=20 >>> Is "no stats yet" really an error?=20 >=20 > This is a special case where the guest hasn't ever filled QEMU with bal= loon > stats. There are two possible cases. Either the guest hasn't done it ye= t, but > will do in the future or the guest will never do it (eg. the guest does= n't > support balloon, the guest crashed, etc). >=20 >>> Libvirt has done nothing wrong, and >>> I'd argue the guest hasn't done anything wrong, either. Should we >>> simply return an empty result? Like "cat" on a file that hasn't gott= en >>> its data, yet. >> >> Yes, that would be reasonable. >=20 > I'm fine with the two possible solutions here: adding a new TryAgain er= ror > class or returning an "empty" result. >=20 > I say "empty" because those fields are not optionals, so we'll have to = fill > them with some value. Shouldn't be a problem for most fields, as the sp= ec > (docs/virtio-balloon-stats.txt) already defines that stats that the gue= st > doesn't report are returned as -1. The only exception here is the last-= update > field, which can't hold a negative iirc. The only choice is to return 0= there. > I guess that this shouldn't be a problem either. >=20 > Who volunteers to fix this? >=20 I've tried: http://marc.info/?l=3Dqemu-devel&m=3D140048179520115&w=3D2 Jan --wQqkLk7hltAfPXOHqSTqAmDfkh8Sa0pPn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTeai3AAoJEMr6XT10/wJphKEQAJPriZmHsOrXL5CspWIk9zAu +DKAgG2sUPAH1B47TnY3k3Yp/UQGx/q2854/C5cdfwM7nI6a4FSHzOoIQXc24YWL 8fNBR9JqahafXmvL5qdiKlxf7avlyst3OXq/wH/uEVUdlYJNS7Pett2kcZGBbtJS ADoo+zov5JnsNf+y+4kQG+0W15RkDjz6hgm14Em/6J0b7HqzcpOByQ/Uh7la4nN5 shw6M3yzopyoRfoG5vpSvrfGvaKfoz7E2lxYBmFF7X1nLQq1CavJp9NtHi5S2+iG uXZyW7DyBs/Fa3gOZpclit+OUn9lo3c/sgXqPFsvVe8peK5kGEyj78hVDVPoMMrf e0l2N7H20U1Lz9P1ppbQDeVt1qSrme8Rmf+4RF+JL92QOQ5VciHOCwbPVZ+v2UsX bcUICaoRgRixfx3ypePi9ogDqA0EnuhFfjdfMboZHGML5kysGczPjfqeBur+lC1r x+uYb7pw5+67NUr8vproEsBBn61dfbwNjrNTbN5J8tCo+KSUDRoNQPYHveYGuOId wlnrKbIL5EapPQR5Ic+UtRzqTC3Ll2v2V/1L9NrzTx4z2MOK8iYAVyW/nWjBIhl5 2/vdIAYcAUJleV7RqMPmeznOIA81nGi+BHcRsOfr30AAeB2OoxekGPRqsJpH+Jlo yQLcDD7JZkJG6GKKR277 =8xsg -----END PGP SIGNATURE----- --wQqkLk7hltAfPXOHqSTqAmDfkh8Sa0pPn--