From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48772)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1WmMHJ-0007Vl-9B
	for qemu-devel@nongnu.org; Mon, 19 May 2014 08:02:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1WmMHC-00020r-Gi
	for qemu-devel@nongnu.org; Mon, 19 May 2014 08:02:49 -0400
Received: from cantor2.suse.de ([195.135.220.15]:40812 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1WmMHC-00020n-BH
	for qemu-devel@nongnu.org; Mon, 19 May 2014 08:02:42 -0400
Message-ID: <5379F2DF.2040909@suse.de>
Date: Mon, 19 May 2014 14:02:39 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <20140519063132.22955.63563.stgit@bahia.local>
In-Reply-To: <20140519063132.22955.63563.stgit@bahia.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RFC V2 0/8] virtio: migrate new properties
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>, Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@amazon.com>, "Michael S. Tsirkin" <mst@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Amit Shah <amit.shah@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>, Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org, =?UTF-8?B?QW5kcmVh?= =?UTF-8?B?cyBGw6RyYmVy?= <afaerber@suse.de>


On 19.05.14 10:38, Greg Kurz wrote:
> Hi,
>
> This patch set tries to address comments from the initial
> review. For this round, I have focused on two changes:
> - as suggested by Andreas, we now call the device specific
>    code from the generic code to ease the implementation of
>    future devices. This is achieved with the addition of
>    load/save methods to VirtioDeviceClass.
> - virtio subsections now implement a "needed" concept with
>    the same semantics as in the VMState code.
>
> I haven't looked at compat mode issues yet, but it is
> on my TODO list.

If you fix up the comments to be either

   /*
    * foo
    */

or

   /* foo */

style, not

   /* foo
    */

then you get my


Acked-by: Alexander Graf <agraf@suse.de>


Alex