From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmP7e-0000yV-3h for qemu-devel@nongnu.org; Mon, 19 May 2014 11:05:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WmP7Z-000382-4m for qemu-devel@nongnu.org; Mon, 19 May 2014 11:05:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15847) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmP7Y-00037H-T3 for qemu-devel@nongnu.org; Mon, 19 May 2014 11:04:57 -0400 Message-ID: <537A1D90.5090600@redhat.com> Date: Mon, 19 May 2014 09:04:48 -0600 From: Eric Blake MIME-Version: 1.0 References: <1400484363-4744-1-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1400484363-4744-1-git-send-email-arei.gonglei@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jQ6skN326GeqS4abbsswq2HI0AIFfKwGp" Subject: Re: [Qemu-devel] [PATCH] qga: Fix handle fd leak in acquire_privilege() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: lcapitulino@redhat.com, mdroth@linux.vnet.ibm.com, Wang Rui , armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jQ6skN326GeqS4abbsswq2HI0AIFfKwGp Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/19/2014 01:26 AM, arei.gonglei@huawei.com wrote: > From: Gonglei >=20 > token should be closed in all conditions. > So move CloseHandle(token) to "out" branch. >=20 > Signed-off-by: Wang Rui > Signed-off-by: Gonglei > --- > qga/commands-win32.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --jQ6skN326GeqS4abbsswq2HI0AIFfKwGp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTeh2QAAoJEKeha0olJ0NqtggH/3ZQ2F/si5j16BgbmMT0J9Ee dVRsO7iKQaIlRxoZWeHQDTp/nWQGULv2vRcTrLCEVlZ3Zc3NJhv2SVk3lZsXXA1p 9yURYQM2vsD49Gm15Ocy+t6bJK2AnQijneDDhtkc11A20xbpnAVE5E54NatHK4yv a9TC4AFFH+5WnDNbLr+n3WvMEfva2hZVYL0r+AdJACXCGYQLDqFljSbdvRoESJz6 XbCqfOicacqspA0DmnYeCLPwWC3s3TAcwXUmZnNr7Iixq72AElql0Tm9Xc8XJU6B m3tnP9u1ShJmmkj1b0KtLQtvsC0ZCQr9hClZR4gFxpT2/tCNWALT6rJ0aH3msOk= =U7pv -----END PGP SIGNATURE----- --jQ6skN326GeqS4abbsswq2HI0AIFfKwGp--