From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43676)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1WmPcO-0004su-1R
	for qemu-devel@nongnu.org; Mon, 19 May 2014 11:36:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1WmPcH-0007RC-Av
	for qemu-devel@nongnu.org; Mon, 19 May 2014 11:36:47 -0400
Received: from cantor2.suse.de ([195.135.220.15]:46105 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1WmPcH-0007R6-5a
	for qemu-devel@nongnu.org; Mon, 19 May 2014 11:36:41 -0400
Message-ID: <537A2506.9070307@suse.de>
Date: Mon, 19 May 2014 17:36:38 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <20140519063132.22955.63563.stgit@bahia.local>
	<5379F2DF.2040909@suse.de> <20140519151008.GA22363@redhat.com>
In-Reply-To: <20140519151008.GA22363@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RFC V2 0/8] virtio: migrate new properties
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, Anthony Liguori <aliguori@amazon.com>, Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Amit Shah <amit.shah@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, =?ISO-8859-1?Q?Andre?= =?ISO-8859-1?Q?as_F=E4rber?= <afaerber@suse.de>, Greg Kurz <gkurz@linux.vnet.ibm.com>


On 19.05.14 17:10, Michael S. Tsirkin wrote:
> On Mon, May 19, 2014 at 02:02:39PM +0200, Alexander Graf wrote:
>> On 19.05.14 10:38, Greg Kurz wrote:
>>> Hi,
>>>
>>> This patch set tries to address comments from the initial
>>> review. For this round, I have focused on two changes:
>>> - as suggested by Andreas, we now call the device specific
>>>    code from the generic code to ease the implementation of
>>>    future devices. This is achieved with the addition of
>>>    load/save methods to VirtioDeviceClass.
>>> - virtio subsections now implement a "needed" concept with
>>>    the same semantics as in the VMState code.
>>>
>>> I haven't looked at compat mode issues yet, but it is
>>> on my TODO list.
>> If you fix up the comments to be either
>>
>>    /*
>>     * foo
>>     */
>>
>> or
>>
>>    /* foo */
>>
>> style, not
>>
>>    /* foo
>>     */
>>
>> then you get my
>>
>>
>> Acked-by: Alexander Graf <agraf@suse.de>
>>
>>
>> Alex
> Documented anywhere?

Impressive. I thought it was, but apparently I'm wrong :). Nevermind then.

> Linux style is
>
>          /* Always
>           * like this.
>           */
>
> so it's definitely not universal.

Eh - documented anywhere? Linux usually goes with C style comments.


Alex