From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46248) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmPnZ-0001kG-Sq for qemu-devel@nongnu.org; Mon, 19 May 2014 11:48:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WmPnV-0002sN-Nu for qemu-devel@nongnu.org; Mon, 19 May 2014 11:48:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19911) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmPnV-0002sJ-G0 for qemu-devel@nongnu.org; Mon, 19 May 2014 11:48:17 -0400 Message-ID: <537A27BD.5050806@redhat.com> Date: Mon, 19 May 2014 09:48:13 -0600 From: Eric Blake MIME-Version: 1.0 References: <1400367823-32610-1-git-send-email-marc.mari.barcelo@gmail.com> <1400367823-32610-3-git-send-email-marc.mari.barcelo@gmail.com> In-Reply-To: <1400367823-32610-3-git-send-email-marc.mari.barcelo@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="D2eMVo2cOoHiHHFRSWjlgpbRsVBLb7kh3" Subject: Re: [Qemu-devel] [PATCH v3 02/16] x86: Convert debug printfs to QEMU_DPRINTF List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TWFyYyBNYXLDrQ==?= , "qemu-devel@nongnu.org" Cc: Stefan Hajnoczi , Peter Crosthwaite , xen-devel@lists.xensource.com, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , kvm@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --D2eMVo2cOoHiHHFRSWjlgpbRsVBLb7kh3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable [resend, because I got: ----- The following addresses had permanent fatal errors ----- (reason: 550 Invalid address in message header) I think it was complaining about: CC: open list:X86 CC: open list:X86 where the RFCs say you should enclose : inside "", as in: CC: "open list:X86" <...> to be fully compliant.] On 05/17/2014 05:03 PM, Marc Mar=C3=AD wrote: > Modify debug macros to have the same format through the codebase and us= e regular > ifs instead of ifdef. >=20 > Signed-off-by: Marc Mar=C3=AD > --- > hw/i386/kvm/pci-assign.c | 11 ++++++----- > hw/i386/multiboot.c | 7 +++++-- > target-i386/kvm.c | 9 +++++---- > xen-hvm.c | 9 +++++---- > xen-mapcache.c | 9 +++++---- > 5 files changed, 26 insertions(+), 19 deletions(-) >=20 > #ifdef DEVICE_ASSIGNMENT_DEBUG > -#define DEBUG(fmt, ...) \ > - do { \ > - fprintf(stderr, "%s: " fmt, __func__ , __VA_ARGS__); \ > - } while (0) > +#define DEVICE_ASSIGNMENT_DEBUG_ENABLED 1 > #else > -#define DEBUG(fmt, ...) > +#define DEVICE_ASSIGNMENT_DEBUG_ENABLED 0 > #endif > =20 > +#define DEBUG(fmt, ...) \ > + QEMU_DPRINTF(DEVICE_ASSIGNMENT_DEBUG_ENABLED, \ > + "pci_assign", fmt, ## __VA_ARGS__) > + Style - you are replacing aligned \ continuation with one-space \ continuation. I don't know if we have a distinct preference, but it's probably better to leave the style unchanged if checkpatch.pl doesn't complain about either way. As that's minor, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --D2eMVo2cOoHiHHFRSWjlgpbRsVBLb7kh3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTeie9AAoJEKeha0olJ0Nq2xAIAKLxYyRtEwltUDN6FkOPaldq d/cUdxlMqQiQNoE0G45DE+Oh7zdQxdvK26LSN0fS4yk2DjsanwOJBDZK/Be7JULM IpCMJdThG67eaw7FJS0mF9FPVdrGSRQntsccGpLFgm76Hw+a9+yhjPiuymCtRsZg 00Qhg+Rl3tVSphNv4NzGU79kSpmFn+7t0I3fVBRAVT6p6+waSmiFuBL5vjvGErPz 2v5s3VuqHh+Us92HLhGjX7f6411RIFipoiM409WJbXWqTTs+JGRBeVI09DbI00BD CWDnIbSaGkGLfKWCw1QsDCjVDwtCN/B+MJU8MQqy24tnrZQLZrb9h5MmHTqHZt8= =YH98 -----END PGP SIGNATURE----- --D2eMVo2cOoHiHHFRSWjlgpbRsVBLb7kh3--