From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmPsk-00057Z-Bc for qemu-devel@nongnu.org; Mon, 19 May 2014 11:53:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WmPsf-0004UH-TA for qemu-devel@nongnu.org; Mon, 19 May 2014 11:53:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50687) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmPsf-0004U9-KV for qemu-devel@nongnu.org; Mon, 19 May 2014 11:53:37 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4JFrbUa004225 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 19 May 2014 11:53:37 -0400 Message-ID: <537A28FF.5040705@redhat.com> Date: Mon, 19 May 2014 09:53:35 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399858555-9672-1-git-send-email-famz@redhat.com> <1399858555-9672-3-git-send-email-famz@redhat.com> In-Reply-To: <1399858555-9672-3-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LxfpXgq20xqIqxEeDU9S8KvmUscu9UIul" Subject: Re: [Qemu-devel] [PATCH v19 02/16] block: Add BlockOpType enum List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: kwolf@redhat.com, jcody@redhat.com, hbrock@redhat.com, rjones@redhat.com, armbru@redhat.com, imain@redhat.com, stefanha@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LxfpXgq20xqIqxEeDU9S8KvmUscu9UIul Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/11/2014 07:35 PM, Fam Zheng wrote: > This adds the enum of all the operations that can be taken on a block > device. >=20 > Signed-off-by: Fam Zheng > Reviewed-by: Benoit Canet > Reviewed-by: Jeff Cody > --- > include/block/block.h | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) Is it worth making this a formal QAPI enum, documented in the .json file? If we ever add qapi introspection, it might be nice to know when new block op types are added as part of the formal qapi definition. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LxfpXgq20xqIqxEeDU9S8KvmUscu9UIul Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTeij/AAoJEKeha0olJ0NqS4MH/3ynksgoh39ObOPnPriD4ewu WRuNFmdpcdcp2YiURNzLTMMiqAHIk0/h0cbt7hAEBuBwae27siifBTqRBaOlnUmO w44VhGNijVvRnH6T3yjGDeGVWHSz+FkAmFFnP52grweoVAOXxQhEaq4A+BJcnKiH NhZr8YdYhsacyoBsDQXm3IkImXGOVoX2kNrMINDwx/nAZYForOZVblBSi9veIwsn qHe1rPHhrQgi8s3fRMgGpSfABycsflou3uyZPsFLEIw5p82XOAdUw7+g3Wix6tf5 uaVVvW7644B128KKKLSKVTn+LszdgbWpJh6kv2k0AeGQAfuTF6KZbRW3Bw7PPwk= =nEEW -----END PGP SIGNATURE----- --LxfpXgq20xqIqxEeDU9S8KvmUscu9UIul--