From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32987)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WmQlZ-0007D5-Dc
	for qemu-devel@nongnu.org; Mon, 19 May 2014 12:50:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WmQlQ-0008Q5-8v
	for qemu-devel@nongnu.org; Mon, 19 May 2014 12:50:21 -0400
Received: from mail-qg0-x22a.google.com ([2607:f8b0:400d:c04::22a]:57692)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WmQlQ-0008Pv-5R
	for qemu-devel@nongnu.org; Mon, 19 May 2014 12:50:12 -0400
Received: by mail-qg0-f42.google.com with SMTP id q107so9400779qgd.29
	for <qemu-devel@nongnu.org>; Mon, 19 May 2014 09:50:11 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <537A363E.309@twiddle.net>
Date: Mon, 19 May 2014 09:50:06 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1400367823-32610-1-git-send-email-marc.mari.barcelo@gmail.com>	<1400367823-32610-4-git-send-email-marc.mari.barcelo@gmail.com>	<CAEgOgz41qfxemdK0DX-Euy97jKCwy5EbisH4MbWDSqExHa9M+g@mail.gmail.com>
	<20140519184526.00364e81@crunchbang>
In-Reply-To: <20140519184526.00364e81@crunchbang>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v3 03/16] s390: Convert debug printfs to
 QEMU_DPRINTF
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?TWFyYyBNYXLDrQ==?= <marc.mari.barcelo@gmail.com>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, Overall <kvm@vger.kernel.org>, Alexander Graf <agraf@suse.de>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>

On 05/19/2014 09:45 AM, Marc Marí wrote:
>> > This STDOUT vs _log() choice is a bit irregular, and I think you might
>> > be better off abandoning it completely. Richard, Alex, do we really
>> > need to optionally route printfery to log or stderr? (considering _log
>> > is NOW stderr by default now, and -D option gives you some flexibility
>> > there). Can we have just log and drop STDOUT mode?
>> > 
>> > Regards,
>> > Peter
> QEMU_DPRINTF outputs to stderr, and, as you say qemu_log does it too.
> Should QEMU_DPRINTF be removed and leave only qemu_log?

Yes, I think that all debug output like this should go via qemu_log.


r~