From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, kraxel@redhat.com, aliguori@amazon.com
Subject: Re: [Qemu-devel] [PATCH v2 3/5] char: Explain qmp_chardev_add()'s unusual error handling
Date: Mon, 19 May 2014 11:16:06 -0600 [thread overview]
Message-ID: <537A3C56.8050200@redhat.com> (raw)
In-Reply-To: <1400518658-2515-4-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 624 bytes --]
On 05/19/2014 10:57 AM, Markus Armbruster wrote:
> Character backend open hasn't been fully converted to the Error API.
> Some opens fail without setting an error. qmp_chardev_add() needs to
> detect when that happens, and set a generic error. Explain that in a
> comment, and inline error_is_set() for clarity.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qemu-char.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-05-19 17:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 16:57 [Qemu-devel] [PATCH v2 0/5] char: Purge error_is_set() Markus Armbruster
2014-05-19 16:57 ` [Qemu-devel] [PATCH v2 1/5] char: Use return values instead of error_is_set(errp) Markus Armbruster
2014-05-19 17:14 ` Eric Blake
2014-05-19 16:57 ` [Qemu-devel] [PATCH v2 2/5] char: Clean up fragile use of error_is_set() Markus Armbruster
2014-05-19 17:15 ` Eric Blake
2014-05-19 16:57 ` [Qemu-devel] [PATCH v2 3/5] char: Explain qmp_chardev_add()'s unusual error handling Markus Armbruster
2014-05-19 17:16 ` Eric Blake [this message]
2014-05-19 16:57 ` [Qemu-devel] [PATCH v2 4/5] qemu-socket: Clean up inet_connect_opts() Markus Armbruster
2014-05-19 16:57 ` [Qemu-devel] [PATCH v2 5/5] error: error_is_set() is finally unused; remove Markus Armbruster
2014-05-19 17:17 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537A3C56.8050200@redhat.com \
--to=eblake@redhat.com \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).