From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmRAb-0007HM-RD for qemu-devel@nongnu.org; Mon, 19 May 2014 13:16:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WmRAW-0000kt-O6 for qemu-devel@nongnu.org; Mon, 19 May 2014 13:16:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43775) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmRAW-0000km-Fq for qemu-devel@nongnu.org; Mon, 19 May 2014 13:16:08 -0400 Message-ID: <537A3C56.8050200@redhat.com> Date: Mon, 19 May 2014 11:16:06 -0600 From: Eric Blake MIME-Version: 1.0 References: <1400518658-2515-1-git-send-email-armbru@redhat.com> <1400518658-2515-4-git-send-email-armbru@redhat.com> In-Reply-To: <1400518658-2515-4-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oDaQR2hPcd4XUCMS3uSw9nt4HlW7Vbp2i" Subject: Re: [Qemu-devel] [PATCH v2 3/5] char: Explain qmp_chardev_add()'s unusual error handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, kraxel@redhat.com, aliguori@amazon.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oDaQR2hPcd4XUCMS3uSw9nt4HlW7Vbp2i Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/19/2014 10:57 AM, Markus Armbruster wrote: > Character backend open hasn't been fully converted to the Error API. > Some opens fail without setting an error. qmp_chardev_add() needs to > detect when that happens, and set a generic error. Explain that in a > comment, and inline error_is_set() for clarity. >=20 > Signed-off-by: Markus Armbruster > --- > qemu-char.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --oDaQR2hPcd4XUCMS3uSw9nt4HlW7Vbp2i Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTejxWAAoJEKeha0olJ0NquX8H/11IRNWVeBBnCf4H39wXdfy4 tm7dV50c6dlAq1bv5n20hUeLmxsM1e+ikw7lOEOjWck6yaTmxIPXTn7YqHNhzfoh gadZ7roeky9iffxmoauTQCLqUhKBzdql/I7FI7xp5LXLErkf65uWOLtAOLRCyuqF 4Rso1r25MU8gXS6o9CjnQ6jIhbgljc83+Xeal69WMr9zYEMwop3DK/9z7BZR5W4y KqRJswu2UZ1HDRJYJwnavN2MTaG8vKg9dDgPbjGZTBAm75KTne/33kjhYnHITNg3 x6l67alurJLtEwBwVnfp7r3nsmSpM/OeE0xlCUQX0BWMaJ1lXTS6cXxCvLXntW8= =/CMk -----END PGP SIGNATURE----- --oDaQR2hPcd4XUCMS3uSw9nt4HlW7Vbp2i--