From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58777)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1WmUl4-0000cq-D9
	for qemu-devel@nongnu.org; Mon, 19 May 2014 17:06:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1WmUkz-0000Bc-C3
	for qemu-devel@nongnu.org; Mon, 19 May 2014 17:06:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:64828)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1WmUkz-0000BF-2b
	for qemu-devel@nongnu.org; Mon, 19 May 2014 17:06:01 -0400
Message-ID: <537A7235.5040107@redhat.com>
Date: Mon, 19 May 2014 15:05:57 -0600
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <1400367823-32610-1-git-send-email-marc.mari.barcelo@gmail.com>
	<1400367823-32610-13-git-send-email-marc.mari.barcelo@gmail.com>
In-Reply-To: <1400367823-32610-13-git-send-email-marc.mari.barcelo@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="UJaHXm983KdArlMSUSq0Qm3uGTsL6n5VI"
Subject: Re: [Qemu-devel] [PATCH v3 12/16] sd: Convert debug printfs to
	QEMU_DPRINTF
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?TWFyYyBNYXLDrQ==?= <marc.mari.barcelo@gmail.com>, qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@gmail.com>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--UJaHXm983KdArlMSUSq0Qm3uGTsL6n5VI
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 05/17/2014 05:03 PM, Marc Mar=C3=AD wrote:
> Modify debug macros to have the same format through the codebase and us=
e regular
> ifs instead of ifdef.
>=20
> Signed-off-by: Marc Mar=C3=AD <marc.mari.barcelo@gmail.com>
> ---
>  hw/sd/sd.c     |    8 +++++---
>  hw/sd/ssi-sd.c |   19 ++++++++++++-------
>  2 files changed, 17 insertions(+), 10 deletions(-)
>=20

> +#define DPRINTF(fmt, ...) \
> +    QEMU_DPRINTF(DEBUG_SSI_SD_ENABLED, "ssi_sd", fmt, ## __VA_ARGS__)
> +#define BADF(fmt, ...) \
> +    do { \
> +        QEMU_DPRINTF(1, "ssi_sd error", fmt, ## __VA_ARGS__); \
> +        if(DEBUG_SSI_SD_ENABLED) { \

Style: space after 'if'

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--UJaHXm983KdArlMSUSq0Qm3uGTsL6n5VI
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJTenI1AAoJEKeha0olJ0NqgaMIAKmU5dxWrOvCkJUcOXtSNVAk
O4tv+dAsvZAeuXQjAZnhqhD1XtGWvhfxy72sgrc6kAQ8MLoZA/+fkFh6RkM7N1Da
Gb2VATZKAFOD9+dngwYuKHrlRvISJAb5Wyy331pUyz5KCqA0d87qGDhxwItGekV/
4tCL61rDWUu8kke3LJFCirLcMD6SCt428IqJdhq2yMOqI6H+lNzOkeGzkqMF8Ohk
1suNX5t3MERzuq50m0J7oUP/vaBDhMR6mPHujBroutKFuvaIvKkXLkLXz/uHJO91
hd6wmr8GYwGMreGzt3Q5oS8qr87KLSsO6HaCbiCYSGOXYUhpmJjoyt9jhnLB47w=
=qjac
-----END PGP SIGNATURE-----

--UJaHXm983KdArlMSUSq0Qm3uGTsL6n5VI--