From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmUmN-0001Wl-HL for qemu-devel@nongnu.org; Mon, 19 May 2014 17:07:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WmUmH-0004q9-U8 for qemu-devel@nongnu.org; Mon, 19 May 2014 17:07:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45092) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmUmH-0004p1-Kv for qemu-devel@nongnu.org; Mon, 19 May 2014 17:07:21 -0400 Message-ID: <537A7286.8000204@redhat.com> Date: Mon, 19 May 2014 15:07:18 -0600 From: Eric Blake MIME-Version: 1.0 References: <1400367823-32610-1-git-send-email-marc.mari.barcelo@gmail.com> <1400367823-32610-14-git-send-email-marc.mari.barcelo@gmail.com> In-Reply-To: <1400367823-32610-14-git-send-email-marc.mari.barcelo@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PxTx221gr2Gi8c76fjA3cei6qPCqmbAEs" Subject: Re: [Qemu-devel] [PATCH v3 13/16] isa: Convert debug printfs to QEMU_DPRINTF List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TWFyYyBNYXLDrQ==?= , qemu-devel@nongnu.org Cc: Stefan Hajnoczi , Peter Crosthwaite , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PxTx221gr2Gi8c76fjA3cei6qPCqmbAEs Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/17/2014 05:03 PM, Marc Mar=C3=AD wrote: > Modify debug macros to have the same format through the codebase and us= e regular > ifs instead of ifdef. >=20 > As the debug printf is always put in code, some formats had to be chang= ed to > avoid warnings treated as errors at compile time.. >=20 > Signed-off-by: Marc Mar=C3=AD > --- > hw/isa/vt82c686.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) >=20 > =20 > - DPRINTF("superio_ioport_writeb address 0x%x val 0x%x\n", addr, d= ata); > + DPRINTF("superio_ioport_writeb address 0x%" PRIx64 " val 0x%" PRI= x64 "\n", Any reason you shortened one double space but left the other intact? I would have expected both or none. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --PxTx221gr2Gi8c76fjA3cei6qPCqmbAEs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTenKGAAoJEKeha0olJ0NqjwgH/jwGuBUGxIbatTxVBlm0luSZ CTSphFyypVbneE3Nyk8KvNhKx3CCgbKy26JRQsYBGexDi3FH8ZDDwNPkE5kzTkOQ zA4wb2ZDm1svhCAye//ki4QeYlHmkd00LmmhGEHjWXHLg/4ujt1ManSRrgYI8lzb w6NqbN9i01YISwyB/r+G81Z36NCigyQ5BnN7H7x7kDBJOzIKW8pKaHS+dYOjakXz XYAVODcaPvcop8Qyx4KaREu3EX2ugTVeM2LYNGtw3Hx8BY3KOjLHob90IgEQQLN+ 6Ty3LFdJjwDOd8Z1NddecWz/ODF6sHWgsULzGrJrz2KEUunjI7E4MowyWMRij1Y= =0xBI -----END PGP SIGNATURE----- --PxTx221gr2Gi8c76fjA3cei6qPCqmbAEs--