From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42157) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wmjas-0005JU-Uz for qemu-devel@nongnu.org; Tue, 20 May 2014 08:56:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wmjal-0000os-P0 for qemu-devel@nongnu.org; Tue, 20 May 2014 08:56:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26452) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wmjal-0000ob-I8 for qemu-devel@nongnu.org; Tue, 20 May 2014 08:56:27 -0400 Message-ID: <537B50EF.6090108@redhat.com> Date: Tue, 20 May 2014 14:56:15 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1400585987-6285-1-git-send-email-lersek@redhat.com> In-Reply-To: <1400585987-6285-1-git-send-email-lersek@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/7] cleanups for compressed dumps (kdumps) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek , qemu-devel@nongnu.org, Luiz Capitulino , Qiao Nuohan , Ekaterina Tumanova , Christian Borntraeger , "Aneesh Kumar K.V" Il 20/05/2014 13:39, Laszlo Ersek ha scritto: > In March Paolo and Luiz had some comments for upstream qemu while they > were reviewing my downstream port of Qiao Nuohan's compressed > (kdump-format) dump feature. I've finally got around addressing them. > > Laszlo Ersek (7): > dump: fill in the flat header signature more pleasingly to the eye > dump: simplify write_start_flat_header() > dump: eliminate DumpState.page_shift ("guest's page shift") > dump: eliminate DumpState.page_size ("guest's page size") > dump: select header bitness based on ELF class, not ELF architecture > dump: hoist lzo_init() from get_len_buf_out() to dump_init() > dump: simplify get_len_buf_out() > > include/sysemu/dump.h | 8 +-- > dump.c | 142 ++++++++++++++++++++++---------------------------- > 2 files changed, 65 insertions(+), 85 deletions(-) > I would have a slight preference for QEMU_BUILD_BUG_ON instead of MIN in patch 1, but that's a really minor nit. Reviewed-by: Paolo Bonzini