From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35853) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmmED-00086E-Aw for qemu-devel@nongnu.org; Tue, 20 May 2014 11:45:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WmmE9-0003dk-1V for qemu-devel@nongnu.org; Tue, 20 May 2014 11:45:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8458) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmmE8-0003dc-PP for qemu-devel@nongnu.org; Tue, 20 May 2014 11:45:16 -0400 Message-ID: <537B7882.3000701@redhat.com> Date: Tue, 20 May 2014 09:45:06 -0600 From: Eric Blake MIME-Version: 1.0 References: <20140428152505.10474.3587.stgit@dhcp-17-12.bos.redhat.com> <20140428152514.10474.67500.stgit@dhcp-17-12.bos.redhat.com> In-Reply-To: <20140428152514.10474.67500.stgit@dhcp-17-12.bos.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HfMGsALEeFH6fFotSpmCAiuM10N68S2wv" Subject: Re: [Qemu-devel] [PATCH v2] qga: Add 'mountpoints' argument to guest-fsfreeze-freeze command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tomoki Sekiyama , qemu-devel@nongnu.org Cc: mitsuhiro.tanino@hds.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HfMGsALEeFH6fFotSpmCAiuM10N68S2wv Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/28/2014 09:25 AM, Tomoki Sekiyama wrote: > When an array of mount point paths is specified as 'mountpoints' argume= nt > of guest-fsfreeze-freeze, qemu-ga with this patch will only freeze the = file > systems mounted on specified paths in Linux. How does the management application learn the set of valid mountpoints arguments it can pass to this command? Shouldn't there be a query counterpart that asks the guest to return the full list of mountpoints that it can support freezing? In the case of guests that are all-or-none, like Windows, the query command would return an empty list to make it obvious there is no ability to freeze just a subset. In returning a list of mountpoint names, it might also be nice to correlate which names map to which devices (it can be a many:many mapping, thanks to things like RAID setups in the guest). > This would be useful when the host wants to create partial disk snapsho= ts. >=20 > Signed-off-by: Tomoki Sekiyama > --- > qga/commands-posix.c | 17 ++++++++++++++++- > qga/commands-win32.c | 3 ++- > qga/qapi-schema.json | 4 ++++ > 3 files changed, 22 insertions(+), 2 deletions(-) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --HfMGsALEeFH6fFotSpmCAiuM10N68S2wv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTe3iCAAoJEKeha0olJ0NqmNEIAJUd2WMTxovKzI6jTvkDlnxc tLzP7HlKaXKysllHZpGOzJjgJs0GsOXqtZpb/bqZYfbzigRsjKSUBHaPjFfR9axT 2DjfZi3Hh16EtXGeTp9N2VXiR8MUEuMgBKr0HJdDXExvH2qi7KpLzNJRHkiQavmj JYkhfoZ26gptyV9ZJSweTXXQqev9KMpIBebT6fcW45ysci/5w5C4QIRUlsgZQUhl 70LRWrxVzkXFRoUfFx8P3VZMki/r94vUsLyi4azkNozEX/0pQu1PoWpdrOcTXiV7 4cr6H9vaK9IzKwUWaqq3aMYLTHCfouGQJ4l8bo0U1L1sg23Knwr5usZx9D4V/7s= =pO90 -----END PGP SIGNATURE----- --HfMGsALEeFH6fFotSpmCAiuM10N68S2wv--