From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmpoI-0003kX-Lu for qemu-devel@nongnu.org; Tue, 20 May 2014 15:34:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WmpoD-0007Us-OH for qemu-devel@nongnu.org; Tue, 20 May 2014 15:34:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7416) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmpoD-0007Um-Gm for qemu-devel@nongnu.org; Tue, 20 May 2014 15:34:45 -0400 Message-ID: <537BAE51.3010905@redhat.com> Date: Tue, 20 May 2014 13:34:41 -0600 From: Eric Blake MIME-Version: 1.0 References: <1400608075-19917-1-git-send-email-sanidhya.iiith@gmail.com> <1400608075-19917-5-git-send-email-sanidhya.iiith@gmail.com> In-Reply-To: <1400608075-19917-5-git-send-email-sanidhya.iiith@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lAH2WVF5jIhXNqTr8U6aqcPTBcWDLWwVd" Subject: Re: [Qemu-devel] [PATCH 4/6] cancel mechanism for an already running dump bitmap process List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sanidhya Kashyap , qemu list Cc: Juan Quintela This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lAH2WVF5jIhXNqTr8U6aqcPTBcWDLWwVd Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/20/2014 11:47 AM, Sanidhya Kashyap wrote: > This patch introduces both hmp and qmp (log-dirty-bitmap-cancel) interf= ace > to cancel an already executing dump process. >=20 > Signed-off-by: Sanidhya Kashyap > --- > +++ b/qapi-schema.json > @@ -4710,3 +4710,8 @@ > '*epochs' : 'int', > '*frequency' : 'int', > '*readable' : 'bool' } } > +## @log-dirty-bitmap-cancel > +# > +# cancel the dirty bitmap logging process > +## Missing 'Since: 2.1'; also, the formatting doesn't quite match other commands where ## is on a line by itself at the start. > +{ 'command': 'log-dirty-bitmap-cancel' } > diff --git a/qmp-commands.hx b/qmp-commands.hx > index 33e7719..55b2251 100644 > --- a/qmp-commands.hx > +++ b/qmp-commands.hx > @@ -3603,3 +3603,23 @@ value is 3 while that of frequency is 40 and rea= dable defaults to false. > =20 > EQMP > =20 > + { > + .name =3D "log-dirty-bitmap-cancel", > + .args_type =3D "", > + .mhandler.cmd_new =3D qmp_marshal_input_log_dirty_bitmap_cance= l, > + }, > + > +SQMP > +log_bitmap_cancel Incorrect command name. > +-------------- > + > +Cancel the current logging of the dirty bitmap. > + > +Arguments: None. > + > +Example: > + > +-> { "execute": "log-bitmap-cancel" } And yet another spelling of an incorrect command name. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --lAH2WVF5jIhXNqTr8U6aqcPTBcWDLWwVd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTe65RAAoJEKeha0olJ0Nqk08IAKQi8D5DabFTGRIrhUyV/pHQ LZYG0sxHWNPODXO8axlYhOqEdtTFhj7ovmDw2OLYE1EhpchcapIb142HNBquj6PS EbEI974RVwmnT5vS3GjEwy+BzSuDQm3Jm5x+kV0e6WslieGU4x51R0o79rwtcUg+ QS+3q5TNNgIKPMvyIUw+wqxuZ9SSzt6K20pkr8pbs9+302Xnf5dn3yJwRzdstA1M Q2HBApMuvoMQV1Y3SAg9fME278epRehwdxG6IEnwpLDeXIHEmvnImAfDdV9Cb0H8 vR5STrPJZwo9N/jyWqy8n7ev0Ns18QLPd/3mNBGso12ylY5Y2+GZwxAhzr8Qj1U= =5YTL -----END PGP SIGNATURE----- --lAH2WVF5jIhXNqTr8U6aqcPTBcWDLWwVd--