From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wmppt-0005E3-2F for qemu-devel@nongnu.org; Tue, 20 May 2014 15:36:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wmppo-0008Fp-5V for qemu-devel@nongnu.org; Tue, 20 May 2014 15:36:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46150) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wmppn-0008Ff-TH for qemu-devel@nongnu.org; Tue, 20 May 2014 15:36:24 -0400 Message-ID: <537BAEB5.2030403@redhat.com> Date: Tue, 20 May 2014 13:36:21 -0600 From: Eric Blake MIME-Version: 1.0 References: <1400608075-19917-1-git-send-email-sanidhya.iiith@gmail.com> <1400608075-19917-6-git-send-email-sanidhya.iiith@gmail.com> In-Reply-To: <1400608075-19917-6-git-send-email-sanidhya.iiith@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EvwX6TMCJWx8xB4CJiJMddUcjfonDDO2H" Subject: Re: [Qemu-devel] [PATCH 5/6] set the frequency of the dump bitmap process List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sanidhya Kashyap , qemu list Cc: Juan Quintela This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EvwX6TMCJWx8xB4CJiJMddUcjfonDDO2H Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/20/2014 11:47 AM, Sanidhya Kashyap wrote: > This patch introduces both qmp and hmp (log-dirty-bitmap-set-frequency)= > interface to update the value of the frequency. >=20 > Signed-off-by: Sanidhya Kashyap > --- > +++ b/qapi-schema.json > @@ -4715,3 +4715,11 @@ > # cancel the dirty bitmap logging process > ## > { 'command': 'log-dirty-bitmap-cancel' } > + > +## @log-dirty-bitmap-set-frequency > +# > +# sets the frequency of the dirty bitmap logging process > +## Same comments as in other patches about missing documentation. > +{ 'command': 'log-dirty-bitmap-set-frequency', > + 'data': {'frequency': 'int' } } > + > diff --git a/qmp-commands.hx b/qmp-commands.hx Please don't end files with an extra blank line. > +Arguments: > + > +- "frequency": the updated frequency (json-int) In what unit? I'm assuming milliseconds based on the rest of the series, but spelling it out will help readers. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --EvwX6TMCJWx8xB4CJiJMddUcjfonDDO2H Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTe661AAoJEKeha0olJ0NqpRAH/j6pSI81zyS+i9tJ8y46cBiL DJ60BIQZUqupnPqZH++6SYgQmTPuY63DUIm+F5wjy2HuTEVszIvAV8IEDlPdJuQM oNOlOD1LXW2AdRBAIVRf1pnjbjRNU7fTXHogLifFq6SlV0oQNvKsvxhhP2T2eFI1 caoI0IBZsI0yLJtH6OgfkUcpcfORGxS3wopxb0kVJUX8Nml8M9lQ9gp3t/SZ/R8w Q1D32kkkvzLphI/ZXObmtUC49KdpaRzqSLXT8aAyb2+8nUgC9FsaWr/dZf5SQjrL aJHbkL1nDjAe6diNhvaF0FX0e+VwxCKl9RiXxiJjzqyKWCzqzTN+5oEdEH803AI= =GrJ0 -----END PGP SIGNATURE----- --EvwX6TMCJWx8xB4CJiJMddUcjfonDDO2H--