From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47901) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmsoI-0002xE-Et for qemu-devel@nongnu.org; Tue, 20 May 2014 18:47:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wmso9-0005CS-0a for qemu-devel@nongnu.org; Tue, 20 May 2014 18:47:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17814) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wmso8-0005AI-P4 for qemu-devel@nongnu.org; Tue, 20 May 2014 18:46:52 -0400 Message-ID: <537BDB56.1010002@redhat.com> Date: Tue, 20 May 2014 16:46:46 -0600 From: Eric Blake MIME-Version: 1.0 References: <20140428152505.10474.3587.stgit@dhcp-17-12.bos.redhat.com> <20140428152514.10474.67500.stgit@dhcp-17-12.bos.redhat.com> <537B7882.3000701@redhat.com> <1400623296-8962-1-git-send-email-tomoki.sekiyama@hds.com> In-Reply-To: <1400623296-8962-1-git-send-email-tomoki.sekiyama@hds.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tNtJM26IjOdB1J2NoJg9drbipW76JAnXg" Subject: Re: [Qemu-devel] [PATCH v2] qga: Add 'mountpoints' argument to guest-fsfreeze-freeze command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tomoki Sekiyama , qemu-devel@nongnu.org Cc: mitsuhiro.tanino@hds.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tNtJM26IjOdB1J2NoJg9drbipW76JAnXg Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/20/2014 04:01 PM, Tomoki Sekiyama wrote: > The patch below is for the command to get filesystems list. >=20 > =3D=3D=3D > From: Tomoki Sekiyama You'll want to resend it as a series of patches as a top-level thread; not everyone notices a patch buried as a reply. >=20 > qga: Add guest-get-fs-info command >=20 > Add command to get mounted filesystems information in the guest. > The returned value contains a list of mountpoint paths and > corresponding disks info such as disk bus type, drive address, > and the disk controllers' PCI addresses, so that management layer > such as libvirt can resolve the disk backends. > In Linux guest, the disk information is resolved from sysfs. >=20 > guest-get-fs-info command will return the following result: >=20 > {"return": > [{"name":"dm-1", > "mountpoint":"/mnt/test", > "disk":[ > {"bus-type":"scsi","bus":0,"unit":1,"target":0, > "pci-controller":{"bus":0,"slot":10,"domain":0,"function":0}},= > {"bus-type":"ide","bus":0,"unit":0,"target":0, > "pci-controller":{"bus":0,"slot":1,"domain":0,"function":1}}],= > "type":"xfs"}, Definitely looks like a useful set of information. I have not reviewed the patch closely, but it looks like you have a good API for Linux. I'm a bit worried that it might be hard to translate this API into non-Linux guests, but it still seems generic enough; and the argument also holds that if this command is not implemented, the guest does not support partial freezing. > +++ b/qga/qapi-schema.json > @@ -646,3 +646,80 @@ > { 'command': 'guest-set-vcpus', > 'data': {'vcpus': ['GuestLogicalProcessor'] }, > + > +## > +# @GuestFilesystemInfo > +# > +# @name: disk name > +# @mountpoint: mount point path > +# @type: file system type string > +# @disk: an array of disk hardware informations that the volume lies o= n s/informations/information/ > +# > +# Since: 2.1 > +## > +{ 'type': 'GuestFilesystemInfo', > + 'data': {'name': 'str', 'mountpoint': 'str', 'type': 'str', > + '*disk': ['GuestDiskAddress']} } Why is the array optional? Is it something where an empty array has different meaning than omitting the array altogether? > + > +## > +# @guest-get-fs-info: > +# > +# Returns: The list of filesystems information mounted in the guest. > +# The returned mountpoints may be specified to @guest-fsfreez= e-freeze. > +# Network filesystems (such as CIFS and NFS) are not listed. > +# > +# Since: 2.1 > +## > +{ 'command': 'guest-get-fs-info', > + 'returns': ['GuestFilesystemInfo'] } Should this command support an optional input argument '*name':'str' that filters the results to a one-element array about that one named mountpoint? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --tNtJM26IjOdB1J2NoJg9drbipW76JAnXg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTe9tWAAoJEKeha0olJ0NqVrsH/35XoZ7gDShKw8rzBhEQHNOE Sd8ZUvxmn9iZoGSJIakBPxTlZl2UF8YWN+91j9nLY+eSmhHtI1VqWSPqcm54MBSV XVMx48XliAWjmMpr0JfdYpypBxzZjPPgTYbIF2xcIA4TUEpwTtoGECLsB3A6Ku2A cbtiz9v45lOGDYqL2kh7TUrlxwvpFhs4S2rhQcO73anaLAUrk/Y7JaCljX/EFSLI gnUjoFI1abSoqrPDV3fcPmqcmI9hvkaEZmO2NksU3J/39M1ipBK4j9hXA1P4THve VYjsF0B9FFsemyWjkGyk/+WQLs791tdwdyJDckaxLNvXkEE6ZAOBm6Ty28NVAwQ= =9xec -----END PGP SIGNATURE----- --tNtJM26IjOdB1J2NoJg9drbipW76JAnXg--