From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wmxal-0004cL-TH for qemu-devel@nongnu.org; Tue, 20 May 2014 23:53:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wmxaf-0001pp-M4 for qemu-devel@nongnu.org; Tue, 20 May 2014 23:53:23 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:47785) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wmxaf-0001pd-Gc for qemu-devel@nongnu.org; Tue, 20 May 2014 23:53:17 -0400 Received: by mail-pd0-f179.google.com with SMTP id x10so968495pdj.10 for ; Tue, 20 May 2014 20:53:16 -0700 (PDT) Message-ID: <537C2326.5040003@ozlabs.ru> Date: Wed, 21 May 2014 13:53:10 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1400644197-6179-1-git-send-email-aik@ozlabs.ru> In-Reply-To: <1400644197-6179-1-git-send-email-aik@ozlabs.ru> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] iscsi: Fix compile error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Paolo Bonzini , Peter Lieven On 05/21/2014 01:49 PM, Alexey Kardashevskiy wrote: > This fixes compile error when LIBISCSI_FEATURE_IOVECTOR is not defined: > > block/iscsi.c|384 col 13| error: 'iscsi_allocationmap_is_allocated' defined but not used [-Werror=unused-f unction] Oops, never mind. Fix is already on its way. > Signed-off-by: Alexey Kardashevskiy > --- > block/iscsi.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/block/iscsi.c b/block/iscsi.c > index d649424..5b3f459 100644 > --- a/block/iscsi.c > +++ b/block/iscsi.c > @@ -380,6 +380,7 @@ retry: > return 0; > } > > +#if defined(LIBISCSI_FEATURE_IOVECTOR) > > static bool iscsi_allocationmap_is_allocated(IscsiLun *iscsilun, > int64_t sector_num, int nb_sectors) > @@ -393,9 +394,6 @@ static bool iscsi_allocationmap_is_allocated(IscsiLun *iscsilun, > sector_num / iscsilun->cluster_sectors) == size); > } > > - > -#if defined(LIBISCSI_FEATURE_IOVECTOR) > - > static int64_t coroutine_fn iscsi_co_get_block_status(BlockDriverState *bs, > int64_t sector_num, > int nb_sectors, int *pnum) > -- Alexey