From: "Andreas Färber" <afaerber@suse.de>
To: Le Tan <tamlokveer@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, peter.crosthwaite@xilinx.com, jan.kiszka@web.de
Subject: Re: [Qemu-devel] [PATCH 1/2] arch_init: replace fprintf(stderr, ...) with error_report()
Date: Wed, 21 May 2014 10:06:09 +0200 [thread overview]
Message-ID: <537C5E71.9060203@suse.de> (raw)
In-Reply-To: <1400631039-7208-2-git-send-email-tamlokveer@gmail.com>
Am 21.05.2014 02:10, schrieb Le Tan:
> Replace fprintf(stderr,...) with error_report() in the file
> arch_init.c. The trailing "\n"s of the @fmt argument have been removed
> because @fmt of error_report() should not contain newline.
>
> Signed-off-by: Le Tan <tamlokveer@gmail.com>
> ---
> arch_init.c | 32 +++++++++++++++-----------------
> 1 file changed, 15 insertions(+), 17 deletions(-)
Reviewed-by: Andreas Färber <afaerber@suse.de>
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-05-21 8:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 0:10 [Qemu-devel] [PATCH 0/2] replace some fprintf(stderr, ...) with error_report() Le Tan
2014-05-21 0:10 ` [Qemu-devel] [PATCH 1/2] arch_init: replace " Le Tan
2014-05-21 8:06 ` Andreas Färber [this message]
2014-05-23 20:11 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-05-21 0:10 ` [Qemu-devel] [PATCH 2/2] block: " Le Tan
2014-05-23 20:27 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-05-24 6:01 ` Le Tan
2014-05-24 6:08 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537C5E71.9060203@suse.de \
--to=afaerber@suse.de \
--cc=jan.kiszka@web.de \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=tamlokveer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).