From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39184) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wn38r-0002nG-2n for qemu-devel@nongnu.org; Wed, 21 May 2014 05:49:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wn38l-0007jm-0K for qemu-devel@nongnu.org; Wed, 21 May 2014 05:48:57 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53308 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wn38k-0007ji-Px for qemu-devel@nongnu.org; Wed, 21 May 2014 05:48:50 -0400 Message-ID: <537C7680.4000000@suse.de> Date: Wed, 21 May 2014 11:48:48 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <20140520150510.GH1657@ERROL.INI.CMU.EDU> <537C6696.9000509@suse.de> <20140521090456.GC19109@redhat.com> <537C6E0A.4020200@suse.de> <20140521092545.GA19646@redhat.com> In-Reply-To: <20140521092545.GA19646@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] e1000: allow command-line selection of card model List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: romain@dolbeau.org, qemu-devel@nongnu.org, agraf@suse.de, "Gabriel L. Somlo" , stefanha@redhat.com, pbonzini@redhat.com Am 21.05.2014 11:25, schrieb Michael S. Tsirkin: > On Wed, May 21, 2014 at 11:12:42AM +0200, Andreas F=E4rber wrote: >> Am 21.05.2014 11:04, schrieb Michael S. Tsirkin: >>> On Wed, May 21, 2014 at 10:40:54AM +0200, Andreas F=E4rber wrote: >>>> Hi, >>>> >>>> Am 20.05.2014 17:05, schrieb Gabriel L. Somlo: >>>>> Allow selection of different card models from the qemu >>>>> command line, to better accomodate a wider range of guests. >>>>> >>>>> Based-on-patch-by: Romain Dolbeau >>>> >>>> If that patch carried a Signed-off-by line, you should retain it. >>> >>> Actually I think that would be confusing. Romain didn't sign off >>> on *this* patch, he signed off on a previous one. >>> A signature by Gabriel indicates Developer's Certificate of Origin 1.= 1 >>> which has an option to incorporate other's work - it >>> does not seem to require signatures by these others. >> >> With the same argument you could drop anyone's Sob you get as a >> maintainer. >=20 > I could but it would not be nice to submitters, and it drops useful inf= o > (author's Sob). So if someone thinks there's problematic code here and > comes complaining, we want to be able to say "this code came from XYZ". >=20 >=20 >> But the purpose of Sob is to track through whose hands a >> patch went, not just who last touched it. >=20 > Went untouched or mostly untouched. > Did you bother checking? > I looked and Romain's patch isn't very similar to this one. >=20 >> My point here was that Based-on-patch-by is very unusual. >=20 > What's the harm? > Gabriel's just being nice and crediting other's work. >=20 >> The alternative would be to leave the original From: Romain Dolbeau, h= is >> Sob, then a [gsomlo: Dropped this, added that] followed by Sob. >> >> Cheers, >> Andreas >=20 > That's just asking submitter to do a lot of extra work, > I don't see why would we place roadblocks in submitter's paths > like this. Linux certainly does not and we didn't ask for this > in the past. >=20 > Further, the patch author in git will also be the original author then > which is only fair if the patch is changed in very minor ways. > In which case keeping the original Sob around *would* be right. Either the patch is based on the patch the submitter claims it is based on, or it is not based on that patch. If it is, then the Sob should be retained because not doing so is dropping useful information as you put it. You will find both ways, From new and old+new Sob or From original and [], in git history, depending on how much changed (which I have not checked here). If it is not based on Romain's patch, then Suggested-by would be much more to the point - and something the maintainer (Stefan) could easily edit when signing off, if there were nothing else to change. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg