From: Paolo Bonzini <pbonzini@redhat.com>
To: Saravanakumar <saravanakumar.punith@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] jazz_led: Add missing break in switch case
Date: Wed, 21 May 2014 13:14:01 +0200 [thread overview]
Message-ID: <537C8A79.1010103@redhat.com> (raw)
In-Reply-To: <1400668900-22972-1-git-send-email-saravanakumar.punith@gmail.com>
Il 21/05/2014 12:41, Saravanakumar ha scritto:
> Signed-off-by: Saravanakumar <saravanakumar.punith@gmail.com>
> ---
> hw/display/jazz_led.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/display/jazz_led.c b/hw/display/jazz_led.c
> index e9bb005..12b1707 100644
> --- a/hw/display/jazz_led.c
> +++ b/hw/display/jazz_led.c
> @@ -173,6 +173,7 @@ static void jazz_led_update_display(void *opaque)
> case 16:
> color_segment = rgb_to_pixel16(0xaa, 0xaa, 0xaa);
> color_led = rgb_to_pixel16(0x00, 0xff, 0x00);
> + break;
> case 24:
> color_segment = rgb_to_pixel24(0xaa, 0xaa, 0xaa);
> color_led = rgb_to_pixel24(0x00, 0xff, 0x00);
>
Reviewed-by: Paolo Bonizni <pbonzini@redhat.com>
next prev parent reply other threads:[~2014-05-21 11:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 10:41 [Qemu-devel] [PATCH] jazz_led: Add missing break in switch case Saravanakumar
2014-05-21 11:14 ` Paolo Bonzini [this message]
2014-05-23 20:08 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537C8A79.1010103@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=saravanakumar.punith@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).