From: Eric Blake <eblake@redhat.com>
To: "Ján Tomko" <jtomko@redhat.com>, qemu-devel@nongnu.org
Cc: mst@redhat.com, aliguori@amazon.com, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] virtio-balloon: return empty data when no stats are available
Date: Wed, 21 May 2014 05:23:51 -0600 [thread overview]
Message-ID: <537C8CC7.8060902@redhat.com> (raw)
In-Reply-To: <337a4c88f373a56ca30698bf1f8772467ddb347d.1400662668.git.jtomko@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]
On 05/21/2014 03:03 AM, Ján Tomko wrote:
> If the guest hasn't updated the stats yet, instead of returning
> an error, return '-1' for the stats and '0' as 'last-update'.
>
> This lets applications ignore this without parsing the error message.
>
> Related libvirt patch and discussion:
> https://www.redhat.com/archives/libvir-list/2014-May/msg00460.html
>
> Tested against current upstream libvirt - stat reporting works and
> it no longer logs errors when the stats are queried on domain startup.
> (Note: libvirt doesn't use the last-update field for anything yet)
>
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
> v1: https://lists.gnu.org/archive/html/qemu-devel/2014-05/msg03643.html
> Reviewed-by: Eric Blake <eblake@redhat.com>
> v2:
> rebased
> added documentation changes
> mentioned testing in the commit message
Additional commit message and doc changes are good.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-05-21 11:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 9:03 [Qemu-devel] [PATCH v2] virtio-balloon: return empty data when no stats are available Ján Tomko
2014-05-21 11:23 ` Eric Blake [this message]
2014-05-21 12:54 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537C8CC7.8060902@redhat.com \
--to=eblake@redhat.com \
--cc=aliguori@amazon.com \
--cc=jtomko@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).