From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wn4cp-0005wh-E7 for qemu-devel@nongnu.org; Wed, 21 May 2014 07:24:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wn4ck-0007ly-Ci for qemu-devel@nongnu.org; Wed, 21 May 2014 07:23:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23483) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wn4ck-0007ls-2x for qemu-devel@nongnu.org; Wed, 21 May 2014 07:23:54 -0400 Message-ID: <537C8CC7.8060902@redhat.com> Date: Wed, 21 May 2014 05:23:51 -0600 From: Eric Blake MIME-Version: 1.0 References: <337a4c88f373a56ca30698bf1f8772467ddb347d.1400662668.git.jtomko@redhat.com> In-Reply-To: <337a4c88f373a56ca30698bf1f8772467ddb347d.1400662668.git.jtomko@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="20Evm0HQotOi2qUHbjeRN2xM3vWf23L3g" Subject: Re: [Qemu-devel] [PATCH v2] virtio-balloon: return empty data when no stats are available List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?SsOhbiBUb21rbw==?= , qemu-devel@nongnu.org Cc: mst@redhat.com, aliguori@amazon.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --20Evm0HQotOi2qUHbjeRN2xM3vWf23L3g Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/21/2014 03:03 AM, J=C3=A1n Tomko wrote: > If the guest hasn't updated the stats yet, instead of returning > an error, return '-1' for the stats and '0' as 'last-update'. >=20 > This lets applications ignore this without parsing the error message. >=20 > Related libvirt patch and discussion: > https://www.redhat.com/archives/libvir-list/2014-May/msg00460.html >=20 > Tested against current upstream libvirt - stat reporting works and > it no longer logs errors when the stats are queried on domain startup. > (Note: libvirt doesn't use the last-update field for anything yet) >=20 > Signed-off-by: J=C3=A1n Tomko > --- > v1: https://lists.gnu.org/archive/html/qemu-devel/2014-05/msg03643.html= > Reviewed-by: Eric Blake > v2: > rebased > added documentation changes > mentioned testing in the commit message Additional commit message and doc changes are good. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --20Evm0HQotOi2qUHbjeRN2xM3vWf23L3g Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTfIzHAAoJEKeha0olJ0NqvZ4IAI8Ymr1uvp6fR7sdzYtCjHbX 3x2UlSnIhK1qcml1utFYETb5lDpsrtJ1l72ThXA0cKFc1JqdyP55xj61KceWDOxn cb6EdDe5vadwa9sr0s5Rq76omIYA8f5tR4W5oKEZc4OrN6iZ4520ZKAFu18eLhgX onyUXTl5nHG+Qg1nWxYgFgf1jEqUc/GonxuOluDYUNGsOvccyMpVVVSDRrItM+FD lU3iInevs30iAO06soS4hAfs23YSrnR28NwdMXiP3E3uwjo6XVqwx3xa49wO+Qe6 47g8BEX4/QJa3UOqUCv2n3PA2L21z0FI6D2mwux2BrU+LOaBgE/ktFuiGJOVIAs= =gntT -----END PGP SIGNATURE----- --20Evm0HQotOi2qUHbjeRN2xM3vWf23L3g--