From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37977)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1Wn4uq-0000jL-Jc
	for qemu-devel@nongnu.org; Wed, 21 May 2014 07:42:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1Wn4uj-0005UI-Tv
	for qemu-devel@nongnu.org; Wed, 21 May 2014 07:42:36 -0400
Received: from mout.web.de ([212.227.17.12]:51785)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1Wn4uj-0005U0-Km
	for qemu-devel@nongnu.org; Wed, 21 May 2014 07:42:29 -0400
Message-ID: <537C911B.5060304@web.de>
Date: Wed, 21 May 2014 13:42:19 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
MIME-Version: 1.0
References: <20140520142929.37e2cb7f@redhat.com>
In-Reply-To: <20140520142929.37e2cb7f@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] scripts/qapi.py: Avoid syntax not
 supported by Python 2.4
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Cc: peter.maydell@linaro.org, vilanova@ac.upc.edu, armbru@redhat.com

Am 20.05.2014 20:29, schrieb Luiz Capitulino:
> The Python "except Foo as x" syntax was only introduced in
> Python 2.6, but we aim to support Python 2.4 and later.
> Use the old-style "except Foo, x" syntax instead, thus
> fixing configure/compile on systems with older Python.
> 
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  scripts/qapi.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/qapi.py b/scripts/qapi.py
> index 0265b40..86e9608 100644
> --- a/scripts/qapi.py
> +++ b/scripts/qapi.py
> @@ -116,7 +116,7 @@ class QAPISchema:
>                      continue
>                  try:
>                      fobj = open(include_path, 'r')
> -                except IOError as e:
> +                except IOError, e:
>                      raise QAPIExprError(expr_info,
>                                          '%s: %s' % (e.strerror, include))
>                  exprs_include = QAPISchema(fobj, include, self.include_hist,

I have the same change applied locally, so

Tested-by: Andreas Färber <andreas.faerber@web.de>

Thanks,
Andreas