From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: Tom Musta <tommusta@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH 1/9] target-ppc: Rename MMCR0/1 contants
Date: Thu, 22 May 2014 12:53:10 +1000 [thread overview]
Message-ID: <537D6696.80301@ozlabs.ru> (raw)
In-Reply-To: <537CDA97.6090204@gmail.com>
On 05/22/2014 02:55 AM, Tom Musta wrote:
> On 5/21/2014 1:20 AM, Alexey Kardashevskiy wrote:
>> MMCR0 and MMCR1 have different numbers for 32 and 64 bit POWERPC.
>> We are going to support 64bit versions too so let's rename 32bit ones
>> to avoid confusion.
>>
>> 604 uses same SPR number for MMCR0 so it is included in this patch too.
>
> I'm not sure that it is a 32-bit vs. 64-bit thing as much as it is an
> evolution of Performance Monitor from individual Book IVs into the
> ISA. Saying differently, the SPR number for MMCR0 is now specified
> in the ISA and is the same for 32 and 64 bit implementations
> ... and is also the same for embedded versus server implementations.
> When the 604 came out, the performance monitor was not yet part of
> the ISA.
The kernel has 2 definitions for MMCR0 and 32 vs. 64 is the condition to
choose one or the other. This is not a spec but still something :)
> Other than that ...
>
> Reviewed-by: Tom Musta <tommusta@gmail.com>
>
--
Alexey
next prev parent reply other threads:[~2014-05-22 2:53 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 6:20 [Qemu-devel] [PATCH 0/9] POWER8 patches Alexey Kardashevskiy
2014-05-21 6:20 ` [Qemu-devel] [PATCH 1/9] target-ppc: Rename MMCR0/1 contants Alexey Kardashevskiy
2014-05-21 16:55 ` Tom Musta
2014-05-22 2:53 ` Alexey Kardashevskiy [this message]
2014-05-21 6:20 ` [Qemu-devel] [PATCH 2/9] target-ppc: Refactor init_proc_POWER7 Alexey Kardashevskiy
2014-05-21 10:44 ` Alexander Graf
2014-05-21 12:30 ` Alexey Kardashevskiy
2014-05-21 13:23 ` Alexander Graf
2014-05-22 3:59 ` Alexey Kardashevskiy
2014-05-22 7:08 ` Alexander Graf
2014-05-21 6:20 ` [Qemu-devel] [PATCH 3/9] target-ppc: Add POWER7 SPRs Alexey Kardashevskiy
2014-05-21 17:17 ` Tom Musta
2014-05-21 6:20 ` [Qemu-devel] [PATCH 4/9] target-ppc: Refactor init_proc_POWER8 Alexey Kardashevskiy
2014-05-21 17:22 ` Tom Musta
2014-05-21 6:20 ` [Qemu-devel] [PATCH 5/9] target-ppc: Add POWER8 SPRs Alexey Kardashevskiy
2014-05-21 10:47 ` Alexander Graf
2014-05-21 18:08 ` Tom Musta
2014-05-21 6:20 ` [Qemu-devel] [PATCH 6/9] target-ppc: Enable PPR and VRSAVE SPRs migration Alexey Kardashevskiy
2014-05-21 10:53 ` Alexander Graf
2014-05-21 6:20 ` [Qemu-devel] [PATCH 7/9] KVM: target-ppc: Enable transactional state migration Alexey Kardashevskiy
2014-05-21 18:11 ` Tom Musta
2014-05-22 2:50 ` Alexey Kardashevskiy
2014-05-22 11:39 ` Tom Musta
2014-05-21 6:20 ` [Qemu-devel] [PATCH 8/9] spapr_hcall: Split h_set_mode() Alexey Kardashevskiy
2014-05-21 6:20 ` [Qemu-devel] [PATCH 9/9] spapr_hcall: Add address-translation-mode-on-interrupt resource in H_SET_MODE Alexey Kardashevskiy
2014-05-21 11:44 ` Alexander Graf
2014-05-21 12:24 ` Alexey Kardashevskiy
2014-05-21 12:25 ` Alexander Graf
2014-05-21 12:26 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537D6696.80301@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=tommusta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).