From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36779) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnJ8I-00084R-Nk for qemu-devel@nongnu.org; Wed, 21 May 2014 22:53:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnJ88-0002xN-S1 for qemu-devel@nongnu.org; Wed, 21 May 2014 22:53:26 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:52937) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnJ88-0002x4-M2 for qemu-devel@nongnu.org; Wed, 21 May 2014 22:53:16 -0400 Received: by mail-pa0-f50.google.com with SMTP id fb1so2017799pad.9 for ; Wed, 21 May 2014 19:53:15 -0700 (PDT) Message-ID: <537D6696.80301@ozlabs.ru> Date: Thu, 22 May 2014 12:53:10 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1400653228-31540-1-git-send-email-aik@ozlabs.ru> <1400653228-31540-2-git-send-email-aik@ozlabs.ru> <537CDA97.6090204@gmail.com> In-Reply-To: <537CDA97.6090204@gmail.com> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/9] target-ppc: Rename MMCR0/1 contants List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tom Musta , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Alexander Graf On 05/22/2014 02:55 AM, Tom Musta wrote: > On 5/21/2014 1:20 AM, Alexey Kardashevskiy wrote: >> MMCR0 and MMCR1 have different numbers for 32 and 64 bit POWERPC. >> We are going to support 64bit versions too so let's rename 32bit ones >> to avoid confusion. >> >> 604 uses same SPR number for MMCR0 so it is included in this patch too. > > I'm not sure that it is a 32-bit vs. 64-bit thing as much as it is an > evolution of Performance Monitor from individual Book IVs into the > ISA. Saying differently, the SPR number for MMCR0 is now specified > in the ISA and is the same for 32 and 64 bit implementations > ... and is also the same for embedded versus server implementations. > When the 604 came out, the performance monitor was not yet part of > the ISA. The kernel has 2 definitions for MMCR0 and 32 vs. 64 is the condition to choose one or the other. This is not a spec but still something :) > Other than that ... > > Reviewed-by: Tom Musta > -- Alexey