From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59957)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WnN2p-0007a6-8D
	for qemu-devel@nongnu.org; Thu, 22 May 2014 03:04:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WnN2g-00077K-3o
	for qemu-devel@nongnu.org; Thu, 22 May 2014 03:04:03 -0400
Received: from mail-ee0-x231.google.com ([2a00:1450:4013:c00::231]:64750)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WnN2f-000777-Sx
	for qemu-devel@nongnu.org; Thu, 22 May 2014 03:03:54 -0400
Received: by mail-ee0-f49.google.com with SMTP id e53so2234240eek.36
	for <qemu-devel@nongnu.org>; Thu, 22 May 2014 00:03:52 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <537DA153.2080501@redhat.com>
Date: Thu, 22 May 2014 09:03:47 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1400740589-3655-1-git-send-email-famz@redhat.com>
	<1400740589-3655-2-git-send-email-famz@redhat.com>
In-Reply-To: <1400740589-3655-2-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] virtio-blk: Factor out
 virtio_blk_handle_scsi_req from virtio_blk_handle_scsi
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>

Il 22/05/2014 08:36, Fam Zheng ha scritto:
> -
> -    if (!req->dev->blk.scsi) {
> -        status = VIRTIO_BLK_S_UNSUPP;
> -        goto fail;
> -    }

Where did you move this condition?

Also, the scsi field of VirtIOBlockReq is now unused.

Paolo