From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39095) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnOZT-0003Ou-BH for qemu-devel@nongnu.org; Thu, 22 May 2014 04:42:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnOZI-0002Zt-K9 for qemu-devel@nongnu.org; Thu, 22 May 2014 04:41:51 -0400 Received: from mail-ee0-x232.google.com ([2a00:1450:4013:c00::232]:33279) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnOZI-0002Zi-Cd for qemu-devel@nongnu.org; Thu, 22 May 2014 04:41:40 -0400 Received: by mail-ee0-f50.google.com with SMTP id e51so2330989eek.23 for ; Thu, 22 May 2014 01:41:39 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <537DB840.3020300@redhat.com> Date: Thu, 22 May 2014 10:41:36 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1400746963-3717-1-git-send-email-famz@redhat.com> In-Reply-To: <1400746963-3717-1-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/2] dataplane: Enable "scsi=on" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Stefan Hajnoczi Il 22/05/2014 10:22, Fam Zheng ha scritto: > This makes the SG_IO code of non-dataplane available to dataplane, so that > dataplane can use to allow scsi=on. > > v3: Change parameter to VirtIOBlock pointer. Undo the swap in code movement. > (Paolo) > > v2: > [1/2] Fix scsi=off case and drop VirtIOBlockReq.scsi. > [2/2] Pass conf to virtio_blk_handle_scsi_req. > > Fam > > > Fam Zheng (2): > virtio-blk: Factor out virtio_blk_handle_scsi_req from > virtio_blk_handle_scsi > dataplane: Support VIRTIO_BLK_T_SCSI_CMD > > hw/block/dataplane/virtio-blk.c | 18 +++++----- > hw/block/virtio-blk.c | 75 ++++++++++++++++++++++------------------- > include/hw/virtio/virtio-blk.h | 3 ++ > 3 files changed, 54 insertions(+), 42 deletions(-) > Reviewed-by: Paolo Bonzini