From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnQWk-0005Sa-2E for qemu-devel@nongnu.org; Thu, 22 May 2014 06:47:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnQWd-00028o-L6 for qemu-devel@nongnu.org; Thu, 22 May 2014 06:47:09 -0400 Message-ID: <537DD5A6.6010609@suse.de> Date: Thu, 22 May 2014 12:47:02 +0200 From: Alexander Graf MIME-Version: 1.0 References: <537CB795.7050702@suse.de> <1400685701-8403-1-git-send-email-aik@ozlabs.ru> In-Reply-To: <1400685701-8403-1-git-send-email-aik@ozlabs.ru> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] spapr: Enable dynamic change of the supported hypercalls list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org On 21.05.14 17:21, Alexey Kardashevskiy wrote: > At the moment the "ibm,hypertas-functions" list is fixed. However some > calls should be listed there if they are supported by QEMU or the host > kernel. > > This enables hyperrtas_prop to grow on stack by adding > a SPAPR_HYPERRTAS_ADD macro. "qemu,hypertas-functions" is converted as well. > > The first user of this is going to be a "multi-tce" property. > > Signed-off-by: Alexey Kardashevskiy > --- > Changes: > v2: > * replaced alloca() with GString > --- > hw/ppc/spapr.c | 30 +++++++++++++++++++++++------- > 1 file changed, 23 insertions(+), 7 deletions(-) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 0a61246..3b28211 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -293,6 +293,10 @@ static size_t create_page_sizes_prop(CPUPPCState *env, uint32_t *prop, > } \ > } while (0) > > +static inline void add_str(GString *s, const gchar *s1) Please remove the "inline" :). Otherwise this looks a lot nicer than before :) Alex