From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnQZ7-0000ZH-8b for qemu-devel@nongnu.org; Thu, 22 May 2014 06:49:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnQYy-0002rp-Ak for qemu-devel@nongnu.org; Thu, 22 May 2014 06:49:37 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48277 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnQYy-0002rg-5H for qemu-devel@nongnu.org; Thu, 22 May 2014 06:49:28 -0400 Message-ID: <537DD636.90500@suse.de> Date: Thu, 22 May 2014 12:49:26 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <05953EE18EEC9148BE892F38DF8F8E8E5ED412@G08CNEXMBPEKD03.g08.fujitsu.local> In-Reply-To: <05953EE18EEC9148BE892F38DF8F8E8E5ED412@G08CNEXMBPEKD03.g08.fujitsu.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC 0/3] cpu: add device_add foo-x86_64-cpu support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "chen.fan.fnst@cn.fujitsu.com" , "qemu-devel@nongnu.org" Cc: Igor Mammedov , Eduardo Habkost , Marcel Apfelbaum Hi, Am 22.05.2014 04:33, schrieb chen.fan.fnst@cn.fujitsu.com: > I think if we want to use 'device/device_add' to implement CPU, > we must do some check before qemu_init_vcpu(). how can we to do that? We ran into such problems before... If need be, we can change from the old parent_realize scheme to the base class calling the derived realize function in-order, or we can add new hooks to CPUClass as necessary. Consider me a bit skeptical about MAX_CPUMASK_BITS in 1/3. This should at least be tied to the maximum allowed for QEMUMachine/MachineClass rather than hardcoded to 255, which people may forget to synchronize. There was a recent attempt to increase the limits. 2/3 looks good apart from the subject; I could cherry-pick that, seeing there is Reviewed-by, if you like. 3/3 is doing a bit much to digest at once for my taste. Regards, Andreas > On Tue, 2014-05-13 at 18:08 +0800, Chen Fan wrote:=20 >> this patches tried to make cpu hotplug with device_add,=20 >> and made -device foo-x86_64-cpu available=EF=BC=8Calso we can >> set apic-id property with command line, if without setting >> apic-id property, we added first unoccupied apic id as the >> default new apic id. and hotplug cpu with device_add, we >> must make check of APIC ID after cpu object initialization >> that was different from 'cpu_add' command which check 'ids' >> at the beginning. >> >> Chen Fan (3): >> using CPUMASK bitmaps to calculate cpu index >> cpu: introduce CpuTopoInfo structure for argument simplification >> cpu: add device_add foo-x86_64-cpu support >> >> exec.c | 9 +++-- >> include/qom/cpu.h | 11 ++++++ >> include/sysemu/sysemu.h | 7 ---- >> qdev-monitor.c | 11 ++++++ >> target-i386/cpu.c | 91 ++++++++++++++++++++++++++++++++++++++++= ++++++++- >> target-i386/topology.h | 51 ++++++++++++++++++--------- >> 6 files changed, 151 insertions(+), 29 deletions(-) --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg