From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49610)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WnQzy-0000Jn-1l
	for qemu-devel@nongnu.org; Thu, 22 May 2014 07:17:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WnQzq-0004m6-Dm
	for qemu-devel@nongnu.org; Thu, 22 May 2014 07:17:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46632)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WnQzq-0004m1-4h
	for qemu-devel@nongnu.org; Thu, 22 May 2014 07:17:14 -0400
Message-ID: <537DDC9F.4030403@redhat.com>
Date: Thu, 22 May 2014 13:16:47 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1400703772-3324-1-git-send-email-stefanha@redhat.com>	<1400703772-3324-2-git-send-email-stefanha@redhat.com>	<537D2342.3000300@redhat.com>
	<CAJSP0QUMER2Fe5AGdVNmEKv-kxzBaDSfa0NNfczvZOVizYSrJQ@mail.gmail.com>
In-Reply-To: <CAJSP0QUMER2Fe5AGdVNmEKv-kxzBaDSfa0NNfczvZOVizYSrJQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/7] qom: add object_property_add_alias()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Frederic Konrad <fred.konrad@greensocs.com>, qemu-devel <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Andreas Faerber <afaerber@suse.de>

Il 22/05/2014 12:23, Stefan Hajnoczi ha scritto:
> I had an intermediate version of this patch with a flag so you could
> tell object_property_add_alias() whether or not to ref the target
> object.  But in the end it seems like overengineering since the
> refcount case is rare or non-existent.  The refcount is a convenience
> feature just for the case where you want to alias to a random object
> that you don't otherwise hold a refcount on (I couldn't think of an
> example).
>
> Do you see what I mean?

Yes, and it makes sense.  Perhaps add a comment for v2.

Paolo