From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33746)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WnkkR-0005yE-3g
	for qemu-devel@nongnu.org; Fri, 23 May 2014 04:22:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WnkkK-0001AZ-8p
	for qemu-devel@nongnu.org; Fri, 23 May 2014 04:22:39 -0400
Received: from mail-ee0-x234.google.com ([2a00:1450:4013:c00::234]:46190)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WnkkK-0001AT-1e
	for qemu-devel@nongnu.org; Fri, 23 May 2014 04:22:32 -0400
Received: by mail-ee0-f52.google.com with SMTP id e53so3434067eek.11
	for <qemu-devel@nongnu.org>; Fri, 23 May 2014 01:22:29 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <537F0542.7050703@redhat.com>
Date: Fri, 23 May 2014 10:22:26 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1400814150-31666-1-git-send-email-famz@redhat.com>
	<1400814150-31666-2-git-send-email-famz@redhat.com>
In-Reply-To: <1400814150-31666-2-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/4] Makefile: Link vscclient with
	libqemuutil.a and libqemustub.a
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Stefan Weil <sw@weilnetz.de>, Michael Tokarev <mjt@tls.msk.ru>, Michael Roth <mdroth@linux.vnet.ibm.com>, Christophe Fergeau <cfergeau@redhat.com>, Alon Levy <alevy@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, =?ISO-8859-1?Q?Alex_Benn=E9e?= <alex.bennee@linaro.org>, Richard Henderson <rth@twiddle.net>

Il 23/05/2014 05:02, Fam Zheng ha scritto:
> Don't include individual objects, just link to archives.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  libcacard/Makefile | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/libcacard/Makefile b/libcacard/Makefile
> index 881b222..abb6eea 100644
> --- a/libcacard/Makefile
> +++ b/libcacard/Makefile
> @@ -3,12 +3,7 @@ libcacard_includedir=$(includedir)/cacard
>  TOOLS += vscclient$(EXESUF)
>
>  # objects linked into a shared library, built with libtool with -fPIC if required
> -libcacard-obj-y = $(stub-obj-y) $(libcacard-y)
> -libcacard-obj-y += util/osdep.o util/cutils.o util/qemu-timer-common.o
> -libcacard-obj-y += util/error.o util/qemu-error.o
> -libcacard-obj-$(CONFIG_WIN32) += util/oslib-win32.o util/qemu-thread-win32.o
> -libcacard-obj-$(CONFIG_POSIX) += util/oslib-posix.o util/qemu-thread-posix.o
> -libcacard-obj-y += $(filter trace/%, $(util-obj-y))
> +libcacard-obj-y = $(libcacard-y)
>
>  libcacard-lobj-y=$(patsubst %.o,%.lo,$(libcacard-obj-y))
>
> @@ -17,7 +12,7 @@ $(libcacard-obj-y): | $(libcacard-lobj-y)
>
>  all: libcacard.la libcacard.pc
>
> -vscclient$(EXESUF): libcacard/vscclient.o libcacard.la
> +vscclient$(EXESUF): libcacard/vscclient.o libcacard.la libqemuutil.a libqemustub.a
>  	$(call LINK,$^)
>
>  #########################################################################
>

Michael was going to drop the dependency altogether.  Also, I am not 
sure this patch is correct because libcacard is built using libtool and 
thus should use .la files rather than .a.

Paolo