From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48653)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WnnmH-00059S-AC
	for qemu-devel@nongnu.org; Fri, 23 May 2014 07:36:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WnnmA-0005i6-Pu
	for qemu-devel@nongnu.org; Fri, 23 May 2014 07:36:45 -0400
Received: from mx1.redhat.com ([209.132.183.28]:10780)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WnnmA-0005hv-GT
	for qemu-devel@nongnu.org; Fri, 23 May 2014 07:36:38 -0400
Message-ID: <537F32BD.5010703@redhat.com>
Date: Fri, 23 May 2014 13:36:29 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1400814150-31666-1-git-send-email-famz@redhat.com>
In-Reply-To: <1400814150-31666-1-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/4] buildsys: Fix module build for
	block-iscsi.so
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Stefan Weil <sw@weilnetz.de>, Michael Tokarev <mjt@tls.msk.ru>, Michael Roth <mdroth@linux.vnet.ibm.com>, Christophe Fergeau <cfergeau@redhat.com>, Alon Levy <alevy@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, =?ISO-8859-15?Q?Alex_Benn=E9e?= <alex.bennee@linaro.org>, Richard Henderson <rth@twiddle.net>

Il 23/05/2014 05:02, Fam Zheng ha scritto:
> We get:
>
>     $ qemu-img
>     Failed to open module: /home/fam/build/master/block-iscsi.so: undefined symbol: bitmap_set
>     qemu-img: Not enough arguments
>     Try 'qemu-img --help' for more information
>
> Because since commit b03c38 (block/iscsi: speed up read for unallocated
> sectors), block/iscsi.c calls utils/bitmap.c:bitmap_* functions, which is not
> linked to qemu-img nor shared objects.
>
> This series links module objects to libqemuutil.a. That requires -fPIC on the
> static library objects. The first patch unifies the dependency path of
> util-obj-y to libqemuutil.a by removing individual object list from
> libcacard-obj-y, so we can apply -fPIC from libqemuutils.a's object specific
> variables.
>
> Also added a travis build task for --enable-modules.
>
> Fam
>
> Fam Zheng (4):
>   Makefile: Link vscclient with libqemuutil.a and libqemustub.a
>   Makefile: Compile libqemustub.a and libqemuutil.a with -fPIC
>   rules.mak: Link DSO with libqemuutil.a
>   .travis.yml: Add a new build target with --enable-modules
>
>  .travis.yml        | 3 +++
>  Makefile           | 1 +
>  libcacard/Makefile | 9 ++-------
>  rules.mak          | 2 +-
>  4 files changed, 7 insertions(+), 8 deletions(-)
>

Applying patch 4.

Paolo