From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnpnR-0000oO-6P for qemu-devel@nongnu.org; Fri, 23 May 2014 09:46:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnpnL-0001Yx-N7 for qemu-devel@nongnu.org; Fri, 23 May 2014 09:46:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14676) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnpnL-0001Ym-3N for qemu-devel@nongnu.org; Fri, 23 May 2014 09:45:59 -0400 Message-ID: <537F5114.9060402@redhat.com> Date: Fri, 23 May 2014 07:45:56 -0600 From: Eric Blake MIME-Version: 1.0 References: <1400852489-31099-1-git-send-email-maria.k@catit.be> In-Reply-To: <1400852489-31099-1-git-send-email-maria.k@catit.be> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="d7k0W5pNnrrg55d1wWXHPLKoRitOqa9ji" Subject: Re: [Qemu-devel] [PATCH] docs: Define refcount_bits value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Maria Kustova , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Maria Kustova , stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --d7k0W5pNnrrg55d1wWXHPLKoRitOqa9ji Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/23/2014 07:41 AM, Maria Kustova wrote: > The 'refcount_bits' term used in the description of refcount block entr= y is > not defined in the specification. The definition is added in the > 'refcount_order' section where refcount_bits was used as 'width in bits= '. >=20 > Signed-off-by: Maria Kustova > --- > docs/specs/qcow2.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake >=20 > diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt > index f19536a..3f713a6 100644 > --- a/docs/specs/qcow2.txt > +++ b/docs/specs/qcow2.txt > @@ -107,8 +107,9 @@ in the description of a field. > =20 > 96 - 99: refcount_order > Describes the width of a reference count block ent= ry (width > - in bits =3D 1 << refcount_order). For version 2 im= ages, the > - order is always assumed to be 4 (i.e. the width is= 16 bits). > + in bits: refcount_bits =3D 1 << refcount_order). F= or version 2 > + images, the order is always assumed to be 4 > + (i.e. refcount_bits =3D 16). > =20 > 100 - 103: header_length > Length of the header structure in bytes. For versi= on 2 >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --d7k0W5pNnrrg55d1wWXHPLKoRitOqa9ji Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTf1EUAAoJEKeha0olJ0NqaRMH/1JRbNXLteNM1iMNT1GXjv3N Ij6Nw8FMFA9o7MEZTvg4+l3x+elhRt77VBBQdzqUz6WOAVekr4CgfEFu+ViOX9Vx MHz9UJPSS9UlkUSgz5XLTBFNoEXVwU5tIBeat2I/UmWqFzPnRwB0pZFmJezmnefc Z0/Z2AwRr/gReVaaaw2B0k4bG1+dgGy12Q30EpqwLMb5XmgnsFYrlDHDp7E6IOmj ng/pYBrBjzHWFS6CRUyU1KYxa1xCxX9xZASaN2Y/A/6XqqCuQHJW1uX7V5JkNHGZ XZ4dVbiwPKm/h3CA0dRjnRB3NRd/XdgfEfHLq9DsWQ6LPBNvI5TibjZLgZXpwPs= =3eMm -----END PGP SIGNATURE----- --d7k0W5pNnrrg55d1wWXHPLKoRitOqa9ji--