qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: alevy@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 0/7] libcacard: A few simple fixes and cleanups
Date: Sat, 24 May 2014 00:54:12 +0400	[thread overview]
Message-ID: <537FB574.8010709@msgid.tls.msk.ru> (raw)
In-Reply-To: <537F917C.2010208@msgid.tls.msk.ru>

23.05.2014 22:20, Michael Tokarev wrote:
> 23.05.2014 15:24, Markus Armbruster wrote:
>> Makes Coverity happy with libcacard/ (for now).
>>
>> v2:
>> - Fix g_new() vs. g_renew() mistake in PATCH 5 [Michael Tokarev]
>> - Trivially rebased
> 
>> Markus Armbruster (7):
>>   libcacard/vscclient: Bury some dead code
>>   libcacard: Plug memory leaks around vreader_get_reader_list()
>>   libcacard/vreader: Drop broken recovery from failed assertion
>>   libcacard/vreader: Tighten assertion to clarify intent
>>   libcacard: Convert two leftover realloc() to GLib
>>   libcacard/vcard_emul_nss: Assert vreaderOpt isn't null
>>   libcacard/vcard_emul_nss: Drop a redundant conditional
> 
> Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
> 
> Except of the vreaderOpt assertion patch which I commented
> separately.
> 
> I think this can easily go to the -trivial tree, as all the
> changes are really trivial.  Including the bugfix, for which
> I can send a patch myself, again, as described in my previous
> reply.

I applied whole series to -trivial, except of this problematic
patch, for which I applied a real fix (will post in another
email).

Good stuff ;)

Thanks,

/mjt

      reply	other threads:[~2014-05-23 20:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-23 11:24 [Qemu-devel] [PATCH v2 0/7] libcacard: A few simple fixes and cleanups Markus Armbruster
2014-05-23 11:24 ` [Qemu-devel] [PATCH v2 1/7] libcacard/vscclient: Bury some dead code Markus Armbruster
2014-05-23 11:24 ` [Qemu-devel] [PATCH v2 2/7] libcacard: Plug memory leaks around vreader_get_reader_list() Markus Armbruster
2014-05-23 11:24 ` [Qemu-devel] [PATCH v2 3/7] libcacard/vreader: Drop broken recovery from failed assertion Markus Armbruster
2014-05-23 11:24 ` [Qemu-devel] [PATCH v2 4/7] libcacard/vreader: Tighten assertion to clarify intent Markus Armbruster
2014-05-23 11:24 ` [Qemu-devel] [PATCH v2 5/7] libcacard: Convert two leftover realloc() to GLib Markus Armbruster
2014-05-23 11:24 ` [Qemu-devel] [PATCH v2 6/7] libcacard/vcard_emul_nss: Assert vreaderOpt isn't null Markus Armbruster
2014-05-23 18:09   ` Michael Tokarev
2014-05-23 18:16     ` Michael Tokarev
2014-05-23 18:18       ` Michael Tokarev
2014-05-26  6:16         ` Markus Armbruster
2014-05-23 11:24 ` [Qemu-devel] [PATCH v2 7/7] libcacard/vcard_emul_nss: Drop a redundant conditional Markus Armbruster
2014-05-23 18:20 ` [Qemu-devel] [PATCH v2 0/7] libcacard: A few simple fixes and cleanups Michael Tokarev
2014-05-23 20:54   ` Michael Tokarev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=537FB574.8010709@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=alevy@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).