From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49044)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Wo8fc-0003HO-Tn
	for qemu-devel@nongnu.org; Sat, 24 May 2014 05:55:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Wo8fT-0007MN-Tl
	for qemu-devel@nongnu.org; Sat, 24 May 2014 05:55:16 -0400
Received: from mail-we0-x235.google.com ([2a00:1450:400c:c03::235]:43325)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Wo8fT-0007La-Ij
	for qemu-devel@nongnu.org; Sat, 24 May 2014 05:55:07 -0400
Received: by mail-we0-f181.google.com with SMTP id w61so5851186wes.40
	for <qemu-devel@nongnu.org>; Sat, 24 May 2014 02:55:06 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <53806C74.3050602@redhat.com>
Date: Sat, 24 May 2014 11:55:00 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1400051861-5848-1-git-send-email-rth@twiddle.net>
	<1400051861-5848-7-git-send-email-rth@twiddle.net>
In-Reply-To: <1400051861-5848-7-git-send-email-rth@twiddle.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 06/24] tcg-mips: Move softmmu slow path out
	of line
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: aurelien@aurel32.net

Il 14/05/2014 09:17, Richard Henderson ha scritto:
> +    tcg_out_opc_imm(s, OPC_LW, TCG_REG_A0, TCG_REG_A0, add_off);
> +    tcg_out_opc_reg(s, OPC_AND, TCG_REG_T0, TCG_REG_T0, addrl);
> +
> +    label_ptr[0] = s->code_ptr;
>      tcg_out_opc_br(s, OPC_BNE, TCG_REG_T0, TCG_REG_AT);
> -    tcg_out_nop(s);

I don't remember mips very well, LW cannot be put in the delay slot? 
This would let you fill both delay slots for the 64-bit case.  Or is it 
just that the code becomes harder to follow due to the TARGET_LONG_BITS 
== 64 "if"s?

Alternatively, for 64-bit you could use OR+BNE instead of BNE+NOP+BNE. 
Of course this can be done later, this patchset is already a big 
improvement.

> +    tcg_out_opc_imm(s, OPC_LW, TCG_REG_A0, TCG_REG_A0, add_off);
> +    tcg_out_opc_reg(s, OPC_AND, TCG_REG_T0, TCG_REG_T0, addrl);
> +
> +    label_ptr[0] = s->code_ptr;
>      tcg_out_opc_br(s, OPC_BNE, TCG_REG_T0, TCG_REG_AT);
> -    tcg_out_nop(s);

Same here.

Paolo