From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50090)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1WoHc2-00032w-Fy
	for qemu-devel@nongnu.org; Sat, 24 May 2014 15:28:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1WoHbv-0003o4-TM
	for qemu-devel@nongnu.org; Sat, 24 May 2014 15:28:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49011)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1WoHbv-0003mp-Kc
	for qemu-devel@nongnu.org; Sat, 24 May 2014 15:28:03 -0400
Message-ID: <5380F2A4.7020309@redhat.com>
Date: Sat, 24 May 2014 21:27:32 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1400794231-27403-1-git-send-email-mreitz@redhat.com>
	<1400794231-27403-3-git-send-email-mreitz@redhat.com>
	<20140523034742.GC1668@T430.nay.redhat.com>
In-Reply-To: <20140523034742.GC1668@T430.nay.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 2/7] configure: Enable out-of-tree
	iotests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Markus Armbruster <armbru@redhat.com>

On 23.05.2014 05:47, Fam Zheng wrote:
> On Thu, 05/22 23:30, Max Reitz wrote:
>> In order to allow out-of-tree iotests, create a symlink for the check
>> script in the build tree.
>>
>> While doing so, also write configured options relevant to the iotests to
>> common.env in the build tree; currently, this is the command to invoke
>> Python 2.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>   configure | 12 ++++++++++++
>>   1 file changed, 12 insertions(+)
>>
>> diff --git a/configure b/configure
>> index 605a0ec..f9d7a4d 100755
>> --- a/configure
>> +++ b/configure
>> @@ -5206,6 +5206,18 @@ if test "$docs" = "yes" ; then
>>     mkdir -p QMP
>>   fi
>>   
>> +# set up qemu-iotests in this build directory
>> +iotests_common_env="tests/qemu-iotests/common.env"
>> +iotests_check="tests/qemu-iotests/check"
>> +
>> +echo "# Automatically generated by configure - do not modify" > "$iotests_common_env"
>> +echo >> "$iotests_common_env"
>> +echo "export PYTHON='$python'" >> "$iotests_common_env"
>> +
>> +if [ ! -e "$iotests_check" ]; then
>> +    ln -s "$source_path/$iotests_check" "$iotests_check"
>> +fi
>> +
> Please use symlink().

I'll do.

Max