From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51870) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WoHnr-00004s-BM for qemu-devel@nongnu.org; Sat, 24 May 2014 15:40:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WoHnl-00080z-7D for qemu-devel@nongnu.org; Sat, 24 May 2014 15:40:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38832) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WoHnk-00080r-Uz for qemu-devel@nongnu.org; Sat, 24 May 2014 15:40:17 -0400 Message-ID: <5380F59A.4030601@redhat.com> Date: Sat, 24 May 2014 21:40:10 +0200 From: Max Reitz MIME-Version: 1.0 References: <1400794231-27403-1-git-send-email-mreitz@redhat.com> <1400794231-27403-4-git-send-email-mreitz@redhat.com> <20140523061001.GG1668@T430.nay.redhat.com> <537F3EB1.3030200@redhat.com> <87k39cmxg9.fsf@blackfin.pond.sub.org> In-Reply-To: <87k39cmxg9.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 3/7] iotests: Add default common.env List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Eric Blake Cc: Kevin Wolf , Peter Maydell , Fam Zheng , qemu-devel@nongnu.org, Stefan Hajnoczi On 23.05.2014 15:33, Markus Armbruster wrote: > Eric Blake writes: > >> On 05/23/2014 12:10 AM, Fam Zheng wrote: >>> On Thu, 05/22 23:30, Max Reitz wrote: >>>> Add a default common.env in case the one supposed to be emitted by >>>> configure cannot be found. >>>> >>>> Signed-off-by: Max Reitz >>> Now we can run both from in-tree build and out-of-tree build without this, >>> which is already very good, but we need this patch to run from the source tree >>> with an out-of-tree build. I'm not sure we really need that, though. >> If you have a source tree but no in-tree build, then there is no way to >> know how many out-of-tree builds there are, or which one you should >> pick. If you are going to do out-of-tree builds, you aren't going to >> try to run tests from the source tree. > Let's not try to guess a build tree. > > If someone tries to run tests in the source tree, and the source tree > has not been made a build tree by running configure there, simply fail. Okay, as you and Fam (and probably also Eric) seem to agree on this, I'll drop this patch and try to make the error message for failing to include common.env more explanatory ("make sure the iotests are run from the build tree" or something similar). Max