From: Michael Tokarev <mjt@tls.msk.ru>
To: Le Tan <tamlokveer@gmail.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Peter Crosthwaite" <peter.crosthwaite@xilinx.com>,
qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>,
"Jan Kiszka" <jan.kiszka@web.de>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] block: replace fprintf(stderr, ...) with error_report()
Date: Sun, 25 May 2014 18:48:19 +0400 [thread overview]
Message-ID: <538202B3.10606@msgid.tls.msk.ru> (raw)
In-Reply-To: <CACrq+iLp07O-r8LLnEG67gFPKVNnh7bMy6g90dPUB_L2cKj18w@mail.gmail.com>
25.05.2014 18:45, Le Tan wrote:
> Oh, yes, I may misunderstood it. I just ran ./scripts/checkpatch.pl to
> check files that I touched and fixed those I can fix. So I will send
> the v4 of this patch which just fix the whitespace issues based on v2.
> Is that right? Forgive my being naive. :)
Please stop top-posting.
I told you to use checkpatch against your _patches_, not against the
files you touch.. ;)
Thank you,
/mjt
prev parent reply other threads:[~2014-05-25 14:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-25 2:44 [Qemu-devel] [PATCH v3] block: replace fprintf(stderr, ...) with error_report() Le Tan
2014-05-25 14:29 ` Jan Kiszka
2014-05-25 14:36 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-05-25 14:45 ` Le Tan
2014-05-25 14:48 ` Michael Tokarev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538202B3.10606@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=afaerber@suse.de \
--cc=jan.kiszka@web.de \
--cc=kwolf@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
--cc=tamlokveer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).