From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56843) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wos1A-0001uT-Sx for qemu-devel@nongnu.org; Mon, 26 May 2014 06:20:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wos14-0003mU-Sk for qemu-devel@nongnu.org; Mon, 26 May 2014 06:20:32 -0400 Received: from cantor2.suse.de ([195.135.220.15]:51052 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wos14-0003lk-Ix for qemu-devel@nongnu.org; Mon, 26 May 2014 06:20:26 -0400 Message-ID: <53831565.6060401@suse.de> Date: Mon, 26 May 2014 12:20:21 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <20140526091813.GA31431@lvm> <53830F7A.3060306@redhat.com> <5383100C.3030807@suse.de> In-Reply-To: <5383100C.3030807@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] BUG: commit 50a2c6e breaks KVM/ARM (reset/init vcpu order) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , qemu-devel@nongnu.org Cc: Peter Maydell , kvm@vger.kernel.org, Paolo Bonzini , Guan Xuetao , Christoffer Dall , Richard Henderson Am 26.05.2014 11:57, schrieb Alexander Graf: >=20 > Any reason we're so incredibly inconsistent in what we do during realiz= e > with reset? I would really prefer to ensure we're doing the same thing > on all targets. >=20 >=20 > Alex >=20 > $ grep -R -A 3 -B 3 qemu_init_vcpu target-* > target-alpha/cpu.c- CPUState *cs =3D CPU(dev); > target-alpha/cpu.c- AlphaCPUClass *acc =3D ALPHA_CPU_GET_CLASS(dev); > target-alpha/cpu.c- > target-alpha/cpu.c: qemu_init_vcpu(cs); > target-alpha/cpu.c- > target-alpha/cpu.c- acc->parent_realize(dev, errp); > target-alpha/cpu.c-} Alpha is the main blocker for unifying CPU reset iirc. It does not implement reset at all and thus is not calling it. The struct was not designed for zero'ing things, so there's a mix of data fields and pointers without clear separation to allow memset(), and I have neither a working alpha test image nor the time to investigate this at the moment= . WIP here: https://github.com/afaerber/qemu-cpu/commits/qom-cpu-alpha https://github.com/afaerber/qemu-cpu/commits/qom-cpu-reset According to my commit unicore32 is another odd sock that doesn't reset the CPU - despite implemented iirc. Regards, Andreas > target-unicore32/cpu.c-{ > target-unicore32/cpu.c- UniCore32CPUClass *ucc =3D > UNICORE32_CPU_GET_CLASS(dev); > target-unicore32/cpu.c- > target-unicore32/cpu.c: qemu_init_vcpu(CPU(dev)); > target-unicore32/cpu.c- > target-unicore32/cpu.c- ucc->parent_realize(dev, errp); > target-unicore32/cpu.c-} --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg