From: Eric Blake <eblake@redhat.com>
To: Chrysostomos Nanakos <cnanakos@grnet.gr>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 1/1] block: Support Archipelago as a QEMU block backend
Date: Mon, 02 Jun 2014 08:30:21 -0600 [thread overview]
Message-ID: <538C8A7D.1020402@redhat.com> (raw)
In-Reply-To: <1401718539-11304-2-git-send-email-cnanakos@grnet.gr>
[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]
On 06/02/2014 08:15 AM, Chrysostomos Nanakos wrote:
> VM Image on Archipelago volume is specified like this:
>
> file=archipelago:<volumename>[/mport=<mapperd_port>[:vport=<vlmcd_port>]]
> or
I still think that there is no need to burden the code with this
shorthand...
>
> file.driver=archipelago,file.volume=<volumename>[,file.mport=<mapperd_port>[,
> file.vport=<vlmcd_port>]]
...when this version is easier to support. Older protocols have file=
abuse due to back-compat reasons, but new protocols should not start out
with baggage.
> ---
> MAINTAINERS | 5 +
> block/Makefile.objs | 1 +
> block/archipelago.c | 1174 +++++++++++++++++++++++++++++++++++++++++++++++++++
This is a lot to review at once - is there any reasonable way to break
it into a series of smaller patches?
I still don't see anything added to the QMP blockdev-add command.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-06-02 14:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 14:15 [Qemu-devel] [PATCH v2 0/1] Support Archipelago as a QEMU block backend Chrysostomos Nanakos
2014-06-02 14:15 ` [Qemu-devel] [PATCH v2 1/1] block: " Chrysostomos Nanakos
2014-06-02 14:30 ` Eric Blake [this message]
2014-06-02 15:04 ` Chrysostomos Nanakos
2014-06-02 15:31 ` Kevin Wolf
2014-06-02 15:49 ` Chrysostomos Nanakos
2014-06-02 16:02 ` Eric Blake
2014-06-04 11:30 ` Chrysostomos Nanakos
2014-06-02 15:49 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538C8A7D.1020402@redhat.com \
--to=eblake@redhat.com \
--cc=cnanakos@grnet.gr \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).