From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36495)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1WrTFz-0006xI-Ue
	for qemu-devel@nongnu.org; Mon, 02 Jun 2014 10:30:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1WrTFt-0005hS-Mq
	for qemu-devel@nongnu.org; Mon, 02 Jun 2014 10:30:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:32985)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1WrTFt-0005gY-AS
	for qemu-devel@nongnu.org; Mon, 02 Jun 2014 10:30:29 -0400
Message-ID: <538C8A7D.1020402@redhat.com>
Date: Mon, 02 Jun 2014 08:30:21 -0600
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <1401718539-11304-1-git-send-email-cnanakos@grnet.gr>
	<1401718539-11304-2-git-send-email-cnanakos@grnet.gr>
In-Reply-To: <1401718539-11304-2-git-send-email-cnanakos@grnet.gr>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="GBvl7GFXbR1MuawK6DqPolWAhtmUMv1EJ"
Subject: Re: [Qemu-devel] [PATCH v2 1/1] block: Support Archipelago as a
 QEMU block backend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chrysostomos Nanakos <cnanakos@grnet.gr>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--GBvl7GFXbR1MuawK6DqPolWAhtmUMv1EJ
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 06/02/2014 08:15 AM, Chrysostomos Nanakos wrote:
> VM Image on Archipelago volume is specified like this:
>=20
> file=3Darchipelago:<volumename>[/mport=3D<mapperd_port>[:vport=3D<vlmcd=
_port>]]
> or

I still think that there is no need to burden the code with this
shorthand...

>=20
> file.driver=3Darchipelago,file.volume=3D<volumename>[,file.mport=3D<map=
perd_port>[,
> file.vport=3D<vlmcd_port>]]

=2E..when this version is easier to support.  Older protocols have file=3D=

abuse due to back-compat reasons, but new protocols should not start out
with baggage.


> ---
>  MAINTAINERS         |    5 +
>  block/Makefile.objs |    1 +
>  block/archipelago.c | 1174 +++++++++++++++++++++++++++++++++++++++++++=
++++++++

This is a lot to review at once - is there any reasonable way to break
it into a series of smaller patches?

I still don't see anything added to the QMP blockdev-add command.

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--GBvl7GFXbR1MuawK6DqPolWAhtmUMv1EJ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJTjIp+AAoJEKeha0olJ0NqBHMH/1bKBUrkXkCk2yw5L8dlXFGm
I9UWPymlfPruNQgwlncEAASzVMAA90ChSxt4TeLcuwwDyHMMNPy1SaAtV4D8OSe8
5b/Squ24RY/utZN8CZt3WWLfrx6RHuQ+kbF/UkBowApYpQivT735VPJiwHngc6KO
P0IBgG16OhnJENU8bk/iBNdj+Jbt7OgGmJXNEQ5+X3YYiFjpBcMedK2HFfAfjMeG
bB3OtfvsOO5ID4gWc0FGAcSli6/OzvGDBGS8spgHjU3A2eis/tMfkeVQMJJSP/MA
VAeSKtzSjxyG8bHwSAnesjcVfPKapM03oFOflhOoFESNt8jfGdzVgHt+S0nEWtM=
=kU07
-----END PGP SIGNATURE-----

--GBvl7GFXbR1MuawK6DqPolWAhtmUMv1EJ--