From: Eric Blake <eblake@redhat.com>
To: "Benoît Canet" <benoit.canet@irqsave.net>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Benoit Canet <benoit@irqsave.net>,
stefanha@redhat.com, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH v1 01/72] qapi: Extract ErrorClass definition in qapi/common.json
Date: Mon, 02 Jun 2014 08:40:24 -0600 [thread overview]
Message-ID: <538C8CD8.6000108@redhat.com> (raw)
In-Reply-To: <1401537111-10221-2-git-send-email-benoit.canet@irqsave.net>
[-- Attachment #1: Type: text/plain, Size: 929 bytes --]
On 05/31/2014 05:50 AM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet <benoit@irqsave.net>
> ---
> qapi-schema.json | 28 ++--------------------------
> qapi/common.json | 29 +++++++++++++++++++++++++++++
> 2 files changed, 31 insertions(+), 26 deletions(-)
> create mode 100644 qapi/common.json
>
> --- /dev/null
> +++ b/qapi/common.json
> @@ -0,0 +1,29 @@
> +# -*- Mode: Python -*-
> +#
> +# QAPI common definitions
I know qapi-schema.json lacks a copyright statement (which I assume
implies to mean it is GPLv2+ ?), but if you are going to create a new
file, it would be nice to make the copyright comment explicit.
As the problem is pre-existing, I'm okay fixing it up in a separate
patch at the same time qapi-schema.json is fixed.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-06-02 14:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1401537111-10221-1-git-send-email-benoit.canet@irqsave.net>
2014-06-02 14:37 ` [Qemu-devel] [PATCH v1 00/72] Extract qapi commons and block definitions Eric Blake
[not found] ` <1401537111-10221-2-git-send-email-benoit.canet@irqsave.net>
2014-06-02 14:40 ` Eric Blake [this message]
[not found] ` <1401537111-10221-3-git-send-email-benoit.canet@irqsave.net>
2014-06-02 14:43 ` [Qemu-devel] [PATCH v1 02/72] qapi: Extract VersionInfo definition in qapi/common.json Eric Blake
[not found] ` <1401537111-10221-6-git-send-email-benoit.canet@irqsave.net>
2014-06-02 14:45 ` [Qemu-devel] [PATCH v1 05/72] qapi: Extract query-commands definition into qapi/common.json Eric Blake
[not found] ` <1401537111-10221-7-git-send-email-benoit.canet@irqsave.net>
2014-06-02 14:47 ` [Qemu-devel] [PATCH v1 06/72] qapi: create two block related json modules Eric Blake
[not found] ` <1401537111-10221-9-git-send-email-benoit.canet@irqsave.net>
2014-06-02 14:48 ` [Qemu-devel] [PATCH v1 08/72] qapi: Extract ImageInfoSpecificQCow2 definition into qapi/block-core.json Eric Blake
[not found] ` <1401537111-10221-21-git-send-email-benoit.canet@irqsave.net>
2014-06-02 14:56 ` [Qemu-devel] [PATCH v1 20/72] qapi: Extract BlockStats " Eric Blake
[not found] ` <1401537111-10221-39-git-send-email-benoit.canet@irqsave.net>
2014-06-02 15:04 ` [Qemu-devel] [PATCH v1 38/72] qapi: Extract block-stream " Eric Blake
[not found] ` <1401537111-10221-45-git-send-email-benoit.canet@irqsave.net>
2014-06-03 14:55 ` [Qemu-devel] [PATCH v1 44/72] qapi: Extract drive-mirror-replace " Eric Blake
2014-06-03 15:50 ` Benoît Canet
[not found] ` <1401537111-10221-73-git-send-email-benoit.canet@irqsave.net>
2014-06-03 15:01 ` [Qemu-devel] [PATCH v1 72/72] qapi: Extract nbd-server-stop definition into qapi/block.json Eric Blake
2014-06-04 14:34 ` [Qemu-devel] [PATCH v1 00/72] Extract qapi commons and block definitions Stefan Hajnoczi
2014-06-04 15:18 ` Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538C8CD8.6000108@redhat.com \
--to=eblake@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=benoit@irqsave.net \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).