From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39671) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrTPc-00018G-Tf for qemu-devel@nongnu.org; Mon, 02 Jun 2014 10:40:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrTPX-0001ps-LC for qemu-devel@nongnu.org; Mon, 02 Jun 2014 10:40:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58417) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrTPX-0001pm-CH for qemu-devel@nongnu.org; Mon, 02 Jun 2014 10:40:27 -0400 Message-ID: <538C8CD8.6000108@redhat.com> Date: Mon, 02 Jun 2014 08:40:24 -0600 From: Eric Blake MIME-Version: 1.0 References: <1401537111-10221-1-git-send-email-benoit.canet@irqsave.net> <1401537111-10221-2-git-send-email-benoit.canet@irqsave.net> In-Reply-To: <1401537111-10221-2-git-send-email-benoit.canet@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SUbBPRdF2w8g5frtbVme01JRk56Pw3CbB" Subject: Re: [Qemu-devel] [PATCH v1 01/72] qapi: Extract ErrorClass definition in qapi/common.json List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Benoit Canet , stefanha@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SUbBPRdF2w8g5frtbVme01JRk56Pw3CbB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/31/2014 05:50 AM, Beno=C3=AEt Canet wrote: > Signed-off-by: Benoit Canet > --- > qapi-schema.json | 28 ++-------------------------- > qapi/common.json | 29 +++++++++++++++++++++++++++++ > 2 files changed, 31 insertions(+), 26 deletions(-) > create mode 100644 qapi/common.json >=20 > --- /dev/null > +++ b/qapi/common.json > @@ -0,0 +1,29 @@ > +# -*- Mode: Python -*- > +# > +# QAPI common definitions I know qapi-schema.json lacks a copyright statement (which I assume implies to mean it is GPLv2+ ?), but if you are going to create a new file, it would be nice to make the copyright comment explicit. As the problem is pre-existing, I'm okay fixing it up in a separate patch at the same time qapi-schema.json is fixed. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --SUbBPRdF2w8g5frtbVme01JRk56Pw3CbB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTjIzYAAoJEKeha0olJ0NqhSoH/RAz2GdYpJdKnZUBY342SS8I WR2pa7MKiuiLHkOGHKP7OejvK23YIs+R76ZFqKx4D1P+JazxAZ5OqV/Su6TwzzHB qV8ew5s0X8q0Fh0KjCFZU3TH4NamQwdRSDefK2nAj5tve3jbwmO/rBbJfhPLLIlG F/gA8scC69dNfNlZFfRiUiD/jJ61b9Dn+YP2U6eWfWg5jfzj3mXoQSTth7ICnG8y H1d6qnpP1sANe8CXwnlhkb4l3nUASHAc2b1l8Y5XpE6m8kMcNAc1sdV76SnNOJBy NkzxtbqKgJ+U5loZhjqO+HTabJPfVhew6P7nRvpodQSqcn1hbbfrvvm2g3kft6I= =FLFr -----END PGP SIGNATURE----- --SUbBPRdF2w8g5frtbVme01JRk56Pw3CbB--