From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrTSZ-0005Nq-0B for qemu-devel@nongnu.org; Mon, 02 Jun 2014 10:43:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrTST-0002yB-SC for qemu-devel@nongnu.org; Mon, 02 Jun 2014 10:43:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13459) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrTST-0002x2-JV for qemu-devel@nongnu.org; Mon, 02 Jun 2014 10:43:29 -0400 Message-ID: <538C8D8E.6090405@redhat.com> Date: Mon, 02 Jun 2014 08:43:26 -0600 From: Eric Blake MIME-Version: 1.0 References: <1401537111-10221-1-git-send-email-benoit.canet@irqsave.net> <1401537111-10221-3-git-send-email-benoit.canet@irqsave.net> In-Reply-To: <1401537111-10221-3-git-send-email-benoit.canet@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0TIxel2iuo18dgD6xL6b20Jm8EQJ5nJF1" Subject: Re: [Qemu-devel] [PATCH v1 02/72] qapi: Extract VersionInfo definition in qapi/common.json List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Benoit Canet , stefanha@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0TIxel2iuo18dgD6xL6b20Jm8EQJ5nJF1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/31/2014 05:50 AM, Beno=C3=AEt Canet wrote: > Signed-off-by: Benoit Canet > --- > qapi-schema.json | 26 -------------------------- > qapi/common.json | 27 +++++++++++++++++++++++++++ > 2 files changed, 27 insertions(+), 26 deletions(-) Why the difference in line counts? > + 'package': 'str'} } > + >=20 Ah, because you ended the file in a trailing blank line. git can be set up to have a commit hook that flags trailing blank lines, but as it is cosmetic and probably transient based on the rest of the series, I can overlook it. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --0TIxel2iuo18dgD6xL6b20Jm8EQJ5nJF1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTjI2OAAoJEKeha0olJ0NqoqYH/2tLg+fevHn0lrKdmKBbaCkD P9+53G3bfykF4N/ATKUw8KepIUYoq429ifWsIBRzBeiUo5Z+dbUShEEjWPEal3qb 6+OE1PmKZL62aQxLPKskRu/dvSRE8EbUGbtRINF6n5Uhvcky38UnumUSV+W46s6i I7GbPSmNHmEKiOC6rVkpCpkRgx04ITo8KpDIe+udEUP0IIfGkLFph8tbKipT6jh/ 4wjC6pcd/GKiKgWsXIKTkir28zsG6xeBTuT7C65wRlVTXX1RsTwDHG3AkGuLFhHb mSZZ1ubd9bvDaEILTD68FwEfBw81mXibIITI0pyAWndjAA0v8UUCzFTP65Tdo+A= =fgmH -----END PGP SIGNATURE----- --0TIxel2iuo18dgD6xL6b20Jm8EQJ5nJF1--