From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44790) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrTfb-0005Hw-RN for qemu-devel@nongnu.org; Mon, 02 Jun 2014 10:57:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrTfX-0008V5-8o for qemu-devel@nongnu.org; Mon, 02 Jun 2014 10:57:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52047) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrTfX-0008Uw-0Q for qemu-devel@nongnu.org; Mon, 02 Jun 2014 10:56:59 -0400 Message-ID: <538C90B8.1030106@redhat.com> Date: Mon, 02 Jun 2014 08:56:56 -0600 From: Eric Blake MIME-Version: 1.0 References: <1401537111-10221-1-git-send-email-benoit.canet@irqsave.net> <1401537111-10221-21-git-send-email-benoit.canet@irqsave.net> In-Reply-To: <1401537111-10221-21-git-send-email-benoit.canet@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1h6pKfmQsSCUcXSUBe4CRIPSwFRtIeRbm" Subject: Re: [Qemu-devel] [PATCH v1 20/72] qapi: Extract BlockStats definition into qapi/block-core.json List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Benoit Canet , stefanha@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1h6pKfmQsSCUcXSUBe4CRIPSwFRtIeRbm Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/31/2014 05:50 AM, Beno=C3=AEt Canet wrote: > Signed-off-by: Benoit Canet > --- > qapi-schema.json | 22 ---------------------- > qapi/block-core.json | 22 ++++++++++++++++++++++ > 2 files changed, 22 insertions(+), 22 deletions(-) 7-20: Reviewed-by: Eric Blake And yes, I really do think this is too fine of a split. It would have been faster for me to do a review of a single patch covering all structs moved to block-core.json in one go than it is to review lots of tiny piecemeal patches (as I mentioned in the RFC, it is very easy to do a review-by-sed for large code motion patches, as long as the code moved maintains its relative ordering between the old and new files: https://lists.gnu.org/archive/html/qemu-devel/2014-05/msg06116.html - what I was complaining about there was that you had one patch with changes intermixed into three files, so the code motion no longer had a relative ordering between deletion and insertion lines). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --1h6pKfmQsSCUcXSUBe4CRIPSwFRtIeRbm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTjJC4AAoJEKeha0olJ0Nq9xgIAI6d+sD3TeKdHbvWc3XFLGiK YU8bAaCo0FxzjfW6qoDQ4qGE1l1EsX+ZZOfUm5DjSaQMK0DMSrNEhU7RDjbUCYr5 ZRDyjaIaR2F/LDBCLanaLWpu7+wp815Vf/ybZUo90QaZcCY7AL8TMVnMTXpHzXFB NS3mQnybraJ4376Yt99upuybTO+Fy150bsf6WUMFwMtUSgMww10Zm5Jh9bEppZ2c PzMkNNnH7kfc7RYoOy0oixc6Rg9dJeWJhIVoa3ri5WUNg5sC21Fe06uAFLv/YSH1 PaIIBd0pyxnW2rKTYOxbk+ngaXYMSjHEgtfJWmTTnDD8HWCLJUDRDksaM+S4xmI= =pyVQ -----END PGP SIGNATURE----- --1h6pKfmQsSCUcXSUBe4CRIPSwFRtIeRbm--