From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33738) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrUgg-0006CI-Fd for qemu-devel@nongnu.org; Mon, 02 Jun 2014 12:02:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrUga-0007ua-DO for qemu-devel@nongnu.org; Mon, 02 Jun 2014 12:02:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrUga-0007u2-4m for qemu-devel@nongnu.org; Mon, 02 Jun 2014 12:02:08 -0400 Message-ID: <538C9FFA.90404@redhat.com> Date: Mon, 02 Jun 2014 10:02:02 -0600 From: Eric Blake MIME-Version: 1.0 References: <1401718539-11304-1-git-send-email-cnanakos@grnet.gr> <1401718539-11304-2-git-send-email-cnanakos@grnet.gr> <538C8A7D.1020402@redhat.com> <538C929B.6000304@grnet.gr> <20140602153126.GF4045@noname.str.redhat.com> <538C9D25.80308@grnet.gr> In-Reply-To: <538C9D25.80308@grnet.gr> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TVkLjNEbFLtG6Nrshro0pGVg1cvaaWFQp" Subject: Re: [Qemu-devel] [PATCH v2 1/1] block: Support Archipelago as a QEMU block backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chrysostomos Nanakos , Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TVkLjNEbFLtG6Nrshro0pGVg1cvaaWFQp Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/02/2014 09:49 AM, Chrysostomos Nanakos wrote: >>>> I still think that there is no need to burden the code with this >>>> shorthand... >>> If everyone agrees I can totally remove that part. >> I don't think it's a bad idea to provide a shortcut for human users. T= he >> important point is just that internally it's not the main interface, b= ut >> mapped to the structured option (which I think your patch achieves now= ). I'm okay if you go with Kevin's vote for keeping the shorthand in place. >>>>> block/archipelago.c | 1174 >>>>> +++++++++++++++++++++++++++++++++++++++++++++++++++ >>>> This is a lot to review at once - is there any reasonable way to bre= ak >>>> it into a series of smaller patches? >>> It will be really difficult to break it in smaller patches, and I >>> believe it will more difficult for someone to review it. >> Not sure how much easier the review would become, but the obvious spli= t >> that works almost always is to do a read-only driver in patch 1, and >> then add write and create support in patches 2 and 3. >=20 > I can do that. Eric do you think that I should do it now and resend the= > patches or in the next version in which I will add support for the QMP > blockdev-add command? Up to you. I'm fine with waiting for a v3 that has everything (QMP and split along Kevin's proposal of read-only vs. write/create) rather than list churn of an immediate resend. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --TVkLjNEbFLtG6Nrshro0pGVg1cvaaWFQp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTjJ/6AAoJEKeha0olJ0NqNLoH/0Wv9noAyq18LTiEEsJT331D 5fXnnyPBZzA3OU/tT/+2rnK2yjK5u2BJ1iuP4ugm8cBUor5ZmqVhkz2TbxsbE0vo otLCJSU50FoqkZdcXtzPPxU2NuS73UOxJMS5fvWEclVAvXDm4XkqkpeOnR+NNyh0 bAYdAA/OvyP+LrwJqWEVsoPQPobqG7+xUwtr0cG/IHNYpP2ttMLegDVvvwld6a9+ vcFetQpkkgFKujGf3utCKR5MwQm1JCHU+6+NwZFb8C1GqRxWLpCBZsPPYmq89AXI g5JleRWVYXHkr14prNOftV9DIE8axbdZvOHC2sjV7HuqcoPOKcFhvIU/jtYYVrk= =Hv1X -----END PGP SIGNATURE----- --TVkLjNEbFLtG6Nrshro0pGVg1cvaaWFQp--