From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50153)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WrWjZ-0001F7-9J
	for qemu-devel@nongnu.org; Mon, 02 Jun 2014 14:13:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WrWjQ-0002nf-9a
	for qemu-devel@nongnu.org; Mon, 02 Jun 2014 14:13:21 -0400
Received: from mail-qg0-x229.google.com ([2607:f8b0:400d:c04::229]:36877)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WrWjQ-0002nS-5i
	for qemu-devel@nongnu.org; Mon, 02 Jun 2014 14:13:12 -0400
Received: by mail-qg0-f41.google.com with SMTP id j5so11467206qga.0
	for <qemu-devel@nongnu.org>; Mon, 02 Jun 2014 11:13:11 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <538CBEB3.4090309@twiddle.net>
Date: Mon, 02 Jun 2014 11:13:07 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1401709825-32579-1-git-send-email-kraxel@redhat.com>
In-Reply-To: <1401709825-32579-1-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] gtk: cleanup backend dependencies
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@amazon.com>

On 06/02/2014 04:50 AM, Gerd Hoffmann wrote:
> @@ -1996,6 +1997,9 @@ if test "$gtk" != "no"; then
>          gtk_libs=`$pkg_config --libs $gtkpackage`
>          libs_softmmu="$gtk_libs $libs_softmmu"
>          gtk="yes"
> +        if $pkg_config --exists "$gtkx11package >= $gtkversion"; then
> +            gtk_libs="$gtk_libs -lX11"
> +        fi

You need to move this hunk above the libs_softmmu line,
otherwise the assignment is unused.


r~