From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrXxM-0001vE-Op for qemu-devel@nongnu.org; Mon, 02 Jun 2014 15:31:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WrXxH-0001iV-QC for qemu-devel@nongnu.org; Mon, 02 Jun 2014 15:31:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59398) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WrXxH-0001iP-Hj for qemu-devel@nongnu.org; Mon, 02 Jun 2014 15:31:35 -0400 Message-ID: <538CD111.30604@redhat.com> Date: Mon, 02 Jun 2014 13:31:29 -0600 From: Eric Blake MIME-Version: 1.0 References: <20140530201145.194061806@amt.cnet> <20140602175104.579823673@amt.cnet> <20140602175345.235004414@amt.cnet> In-Reply-To: <20140602175345.235004414@amt.cnet> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Xegv03SvpCiEVFmoQJ2ChaqMkPvWDViCm" Subject: Re: [Qemu-devel] [patch 1/3] mc146818rtc: add rtc_reset_reinjection QMP command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mtosatti@redhat.com, qemu-devel@nongnu.org Cc: gleb@kernel.org, pbonzini@redhat.com, armbru@redhat.com, mprivozn@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Xegv03SvpCiEVFmoQJ2ChaqMkPvWDViCm Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/02/2014 11:51 AM, mtosatti@redhat.com wrote: > It is necessary to reset RTC interrupt reinjection backlog if > guest time is synchronized via a different mechanism, such as=20 > QGA's guest-set-time command. >=20 > Failing to do so causes both corrections to be applied (summed), > resulting in an incorrect guest time. >=20 > Signed-off-by: Marcelo Tosatti >=20 > Index: qemu/hw/timer/mc146818rtc.c Still no --- separator between your commit message and the patch body. Are you using 'git send-email'? > Index: qemu/qapi-schema.json > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- qemu.orig/qapi-schema.json > +++ qemu/qapi-schema.json > @@ -4722,3 +4722,15 @@ > 'btn' : 'InputBtnEvent', > 'rel' : 'InputMoveEvent', > 'abs' : 'InputMoveEvent' } } > + > +## > +# @: rtc-reset-reinjection s/: // to resemble most other commands > +# > +# This command will reset RTC's interrupt reinjection backlog. s/RTC's/the RTC/ > +# Can be used if another mechanism to synchronize guest time > +# is in effect, for example QEMU guest agents guest-set-time s/agents/agent's/ > +# command. > +# > +# Since: 2.1 > +## > +{ 'command': 'rtc-reset-reinjection' } > Index: qemu/qmp-commands.hx > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- qemu.orig/qmp-commands.hx > +++ qemu/qmp-commands.hx > @@ -3572,3 +3572,26 @@ Example: > } } ] } > =20 > EQMP > + > +#if defined (TARGET_I386) > + { > + .name =3D "rtc_reset_reinjection", s/rtc_reset_reinjection/rtc-reset-reinjection/ > + .args_type =3D "", > + .mhandler.cmd_new =3D qmp_marshal_input_rtc_reset_reinjection,= > + }, > +#endif > + > +SQMP > +rtc-reset-reinjection > +--------------------- --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Xegv03SvpCiEVFmoQJ2ChaqMkPvWDViCm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEbBAEBCAAGBQJTjNERAAoJEKeha0olJ0Nqa6EH+KdgeDwfy0L/Hs5yzRwa+SKt b42+n6F8OaDZmcdjY+Ldm0UGx4CNu+DVKR7idmcYCkUf7ai4B625kb6lSF+tLJNt 4th1V17Hp48gTpe3i6PcxWEQR95zz+vPg2/PP33GO1mXhaKQcotI6ri4TJ0QP8z3 zpMjO7EhHBRpjzgfN0D2TUXWYFA+KNxPOBURwye9Buxxr3C/E6z1+bvOsvrt+SAA s3LFwbCCkT2imppxILVOH2lfnelxs3UweWT8KU+Y37dZWonazXh1Oh5dj2K1fU6O +y0CnvB7TKgVE4aQhgtlxEQ1/qavLgUsQjWCMRyb8bqOzYFmE1UDDumWCNNjIA== =FV9k -----END PGP SIGNATURE----- --Xegv03SvpCiEVFmoQJ2ChaqMkPvWDViCm--